public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: eranian@hpl.hp.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] x86_64 add missing enter_idle() calls
Date: Sat, 21 Oct 2006 15:22:53 +0200	[thread overview]
Message-ID: <200610211522.53938.ak@suse.de> (raw)
In-Reply-To: <20061021091837.GA24670@frankl.hpl.hp.com>


> I finally found the culprit for this. The current code is wrong for the
> simple reason that the cpu_idle() function is NOT always the lowest level
> idle loop function. For enter_idle()/__exit_idle() to work correctly they
> must be placed in the lowest-level idle loop. The cpu_idle() eventually ends
> up in the idle() function, but this one may have a loop in it! This is the
> case when idle()=cpu_default_idle() and idle()=poll_idle(), for instance. 

Ah now I remember - i had actually fixed that (it was the cleanup-idle-loops
patch) that moved the loops one level up. But then I disabled the patch
at the request of Andrew because it conflicted with some ACPI idle changes.

I'll readd it for .20, then things should be ok.

-Andi

  reply	other threads:[~2006-10-21 13:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-06  8:16 [PATCH] x86_64 add missing enter_idle() calls Stephane Eranian
2006-10-16 10:08 ` Andi Kleen
2006-10-16 14:13   ` Stephane Eranian
2006-10-16 14:36     ` Andi Kleen
2006-10-16 14:44       ` Stephane Eranian
2006-10-17 16:47       ` Stephane Eranian
2006-10-21  9:18       ` Stephane Eranian
2006-10-21 13:22         ` Andi Kleen [this message]
2006-10-24 10:00           ` Stephane Eranian
2006-10-25 21:29           ` Stephane Eranian
2006-10-27 16:03             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200610211522.53938.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=eranian@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox