public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: patches@x86-64.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [14/19] i386: Disable nmi watchdog on all ThinkPads
Date: Sat, 21 Oct 2006 18:51:34 +0200 (CEST)	[thread overview]
Message-ID: <20061021165134.7ADBB13CB4@wotan.suse.de> (raw)
In-Reply-To: <20061021 651.356252000@suse.de>


Even newer Thinkpads have bugs in SMM code that causes hangs with
NMI watchdog.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 arch/i386/kernel/nmi.c      |   10 +++++-----
 drivers/firmware/dmi_scan.c |   20 ++++++++++++++++++++
 include/linux/dmi.h         |    2 ++
 3 files changed, 27 insertions(+), 5 deletions(-)

Index: linux/arch/i386/kernel/nmi.c
===================================================================
--- linux.orig/arch/i386/kernel/nmi.c
+++ linux/arch/i386/kernel/nmi.c
@@ -219,11 +219,11 @@ static int __init check_nmi_watchdog(voi
 	int cpu;
 
 	/* Enable NMI watchdog for newer systems.
-           Actually it should be safe for most systems before 2004 too except
-	   for some IBM systems that corrupt registers when NMI happens
-	   during SMM. Unfortunately we don't have more exact information
- 	   on these and use this coarse check. */
-	if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004)
+	   Probably safe on most older systems too, but let's be careful.
+	   IBM ThinkPads use INT10 inside SMM and that allows early NMI inside SMM
+	   which hangs the system. Disable watchdog for all thinkpads */
+	if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004 &&
+		!dmi_name_in_vendors("ThinkPad"))
 		nmi_watchdog = NMI_LOCAL_APIC;
 
 	if ((nmi_watchdog == NMI_NONE) || (nmi_watchdog == NMI_DEFAULT))
Index: linux/drivers/firmware/dmi_scan.c
===================================================================
--- linux.orig/drivers/firmware/dmi_scan.c
+++ linux/drivers/firmware/dmi_scan.c
@@ -326,6 +326,26 @@ char *dmi_get_system_info(int field)
 }
 EXPORT_SYMBOL(dmi_get_system_info);
 
+
+/**
+ *	dmi_name_in_vendors - Check if string is anywhere in the DMI vendor information.
+ *	@str: 	Case sensitive Name
+ */
+int dmi_name_in_vendors(char *str)
+{
+	static int fields[] = { DMI_BIOS_VENDOR, DMI_BIOS_VERSION, DMI_SYS_VENDOR,
+				DMI_PRODUCT_NAME, DMI_PRODUCT_VERSION, DMI_BOARD_VENDOR,
+				DMI_BOARD_NAME, DMI_BOARD_VERSION, DMI_NONE };
+	int i;
+	for (i = 0; fields[i] != DMI_NONE; i++) {
+		int f = fields[i];
+		if (dmi_ident[f] && strstr(dmi_ident[f], str))
+			return 1;
+	}
+	return 0;
+}
+EXPORT_SYMBOL(dmi_name_in_vendors);
+
 /**
  *	dmi_find_device - find onboard device by type/name
  *	@type: device type or %DMI_DEV_TYPE_ANY to match all device types
Index: linux/include/linux/dmi.h
===================================================================
--- linux.orig/include/linux/dmi.h
+++ linux/include/linux/dmi.h
@@ -69,6 +69,7 @@ extern struct dmi_device * dmi_find_devi
 	struct dmi_device *from);
 extern void dmi_scan_machine(void);
 extern int dmi_get_year(int field);
+extern int dmi_name_in_vendors(char *str);
 
 #else
 
@@ -77,6 +78,7 @@ static inline char * dmi_get_system_info
 static inline struct dmi_device * dmi_find_device(int type, const char *name,
 	struct dmi_device *from) { return NULL; }
 static inline int dmi_get_year(int year) { return 0; }
+static inline int dmi_name_in_vendors(char *s) { return 0; }
 
 #endif
 

  parent reply	other threads:[~2006-10-21 16:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061021 651.356252000@suse.de>
2006-10-21 16:51 ` [PATCH] [1/19] x86_64: Update defconfig Andi Kleen
2006-10-21 16:51 ` [PATCH] [2/19] i386: " Andi Kleen
2006-10-21 16:51 ` [PATCH] [3/19] x86_64: x86_64 hot-add memory srat.c fix Andi Kleen
2006-10-21 16:51 ` [PATCH] [4/19] x86_64: typo in __assign_irq_vector when updating pos for vector and offset Andi Kleen
2006-10-21 16:51 ` [PATCH] [5/19] i386: fix .cfi_signal_frame copy-n-paste error Andi Kleen
2006-10-21 16:51 ` [PATCH] [6/19] x86_64: Fix for arch/x86_64/pci/Makefile CFLAGS Andi Kleen
2006-10-21 16:51 ` [PATCH] [7/19] x86_64: fix page align in e820 allocator Andi Kleen
2006-10-21 16:51 ` [PATCH] [8/19] x86: Use -maccumulate-outgoing-args Andi Kleen
2006-10-21 17:18   ` Dave Jones
2006-10-21 18:20     ` Andi Kleen
2006-10-21 16:51 ` [PATCH] [9/19] x86_64: Speed up dwarf2 unwinder Andi Kleen
2006-10-21 16:51 ` [PATCH] [10/19] x86_64: x86_64 add NX mask for PTE entry Andi Kleen
2006-10-21 16:51 ` [PATCH] [11/19] i386: Fix fake return address Andi Kleen
2006-10-21 18:12   ` Jeremy Fitzhardinge
2006-10-21 18:14     ` Andi Kleen
2006-10-21 18:17   ` Andreas Schwab
2006-10-21 16:51 ` [PATCH] [12/19] x86_64: Fix ENOSYS in system call tracing Andi Kleen
2006-10-21 16:51 ` [PATCH] [13/19] x86_64: Revert interrupt backlink changes Andi Kleen
2006-10-21 16:51 ` Andi Kleen [this message]
2006-10-21 17:24   ` [PATCH] [14/19] i386: Disable nmi watchdog on all ThinkPads Dave Jones
2006-10-21 18:11     ` [patches] " Andi Kleen
2006-10-21 18:14       ` Dave Jones
2006-10-21 18:22         ` Andi Kleen
2006-10-21 16:51 ` [PATCH] [16/19] x86: Revert new unwind kernel stack termination Andi Kleen
2006-10-21 16:51 ` [PATCH] [18/19] x86_64: Overlapping program headers in physical addr space fix Andi Kleen
2006-10-23  7:20   ` [patches] " Jan Beulich
2006-10-23 14:41     ` Vivek Goyal
2006-10-23 15:02       ` Ian Campbell
2006-10-23 16:08       ` Jan Beulich
2006-10-21 16:51 ` [PATCH] [19/19] x86_64: Revert timer routing behaviour back to 2.6.16 state Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061021165134.7ADBB13CB4@wotan.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@x86-64.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox