From: Dave Jones <davej@redhat.com>
To: Andi Kleen <ak@suse.de>
Cc: patches@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [patches] Re: [PATCH] [14/19] i386: Disable nmi watchdog on all ThinkPads
Date: Sat, 21 Oct 2006 14:14:40 -0400 [thread overview]
Message-ID: <20061021181440.GG30758@redhat.com> (raw)
In-Reply-To: <200610212011.56215.ak@suse.de>
On Sat, Oct 21, 2006 at 08:11:56PM +0200, Andi Kleen wrote:
>
> > > - if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004)
> > > + Probably safe on most older systems too, but let's be careful.
> > > + IBM ThinkPads use INT10 inside SMM and that allows early NMI inside SMM
> > > + which hangs the system. Disable watchdog for all thinkpads */
> > > + if (nmi_watchdog == NMI_DEFAULT && dmi_get_year(DMI_BIOS_DATE) >= 2004 &&
> > > + !dmi_name_in_vendors("ThinkPad"))
> > > nmi_watchdog = NMI_LOCAL_APIC;
> >
> > This is going to get some people scratching their heads wondering
> > why it isn't working if they ever try nmi_watchdog on one of these.
> > How about adding an explanitory printk ?
>
> When you enable it manually then NMI_DEFAULT won't be set and this code
> is never executed.
>
> BTW their machines will likely not stay up long enough that they can
> see the printk (unless Lenovo fixes that particular bug in the future,
> they are aware of it)
Ouch, nasty. I'm surprised no-one complained about this earlier.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-10-21 18:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061021 651.356252000@suse.de>
2006-10-21 16:51 ` [PATCH] [1/19] x86_64: Update defconfig Andi Kleen
2006-10-21 16:51 ` [PATCH] [2/19] i386: " Andi Kleen
2006-10-21 16:51 ` [PATCH] [3/19] x86_64: x86_64 hot-add memory srat.c fix Andi Kleen
2006-10-21 16:51 ` [PATCH] [4/19] x86_64: typo in __assign_irq_vector when updating pos for vector and offset Andi Kleen
2006-10-21 16:51 ` [PATCH] [5/19] i386: fix .cfi_signal_frame copy-n-paste error Andi Kleen
2006-10-21 16:51 ` [PATCH] [6/19] x86_64: Fix for arch/x86_64/pci/Makefile CFLAGS Andi Kleen
2006-10-21 16:51 ` [PATCH] [7/19] x86_64: fix page align in e820 allocator Andi Kleen
2006-10-21 16:51 ` [PATCH] [8/19] x86: Use -maccumulate-outgoing-args Andi Kleen
2006-10-21 17:18 ` Dave Jones
2006-10-21 18:20 ` Andi Kleen
2006-10-21 16:51 ` [PATCH] [9/19] x86_64: Speed up dwarf2 unwinder Andi Kleen
2006-10-21 16:51 ` [PATCH] [10/19] x86_64: x86_64 add NX mask for PTE entry Andi Kleen
2006-10-21 16:51 ` [PATCH] [11/19] i386: Fix fake return address Andi Kleen
2006-10-21 18:12 ` Jeremy Fitzhardinge
2006-10-21 18:14 ` Andi Kleen
2006-10-21 18:17 ` Andreas Schwab
2006-10-21 16:51 ` [PATCH] [12/19] x86_64: Fix ENOSYS in system call tracing Andi Kleen
2006-10-21 16:51 ` [PATCH] [13/19] x86_64: Revert interrupt backlink changes Andi Kleen
2006-10-21 16:51 ` [PATCH] [14/19] i386: Disable nmi watchdog on all ThinkPads Andi Kleen
2006-10-21 17:24 ` Dave Jones
2006-10-21 18:11 ` [patches] " Andi Kleen
2006-10-21 18:14 ` Dave Jones [this message]
2006-10-21 18:22 ` Andi Kleen
2006-10-21 16:51 ` [PATCH] [16/19] x86: Revert new unwind kernel stack termination Andi Kleen
2006-10-21 16:51 ` [PATCH] [18/19] x86_64: Overlapping program headers in physical addr space fix Andi Kleen
2006-10-23 7:20 ` [patches] " Jan Beulich
2006-10-23 14:41 ` Vivek Goyal
2006-10-23 15:02 ` Ian Campbell
2006-10-23 16:08 ` Jan Beulich
2006-10-21 16:51 ` [PATCH] [19/19] x86_64: Revert timer routing behaviour back to 2.6.16 state Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061021181440.GG30758@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@x86-64.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox