From: Dave Jones <davej@redhat.com>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Amit Choudhary <amit2030@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.19-rc2] mm/slab.c: check kmalloc() return value.
Date: Sun, 22 Oct 2006 18:10:34 -0400 [thread overview]
Message-ID: <20061022221034.GE3093@redhat.com> (raw)
In-Reply-To: <20061022211605.GA19617@filer.fsl.cs.sunysb.edu>
On Sun, Oct 22, 2006 at 05:16:05PM -0400, Josef Sipek wrote:
> On Sun, Oct 22, 2006 at 01:37:51PM -0700, Amit Choudhary wrote:
> > Description: Check the return value of kmalloc() in function setup_cpu_cache(), in file mm/slab.c.
> >
> > Signed-off-by: Amit Choudhary <amit2030@gmail.com>
> >
> > diff --git a/mm/slab.c b/mm/slab.c
> > index 84c631f..613ae61 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -2021,6 +2021,7 @@ static int setup_cpu_cache(struct kmem_c
> > } else {
> > cachep->array[smp_processor_id()] =
> > kmalloc(sizeof(struct arraycache_init), GFP_KERNEL);
> > + BUG_ON(!cachep->array[smp_processor_id()]);
> >
> > if (g_cpucache_up == PARTIAL_AC) {
> > set_up_list3s(cachep, SIZE_L3);
>
> Any reason to BUG instead of trying to return as gracefully as possible?
If we fail to allocate memory this early in boot, we're hosed anyway.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-10-22 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-22 20:37 [PATCH 2.6.19-rc2] mm/slab.c: check kmalloc() return value Amit Choudhary
2006-10-22 21:16 ` Josef Sipek
2006-10-22 22:10 ` Dave Jones [this message]
2006-10-23 6:38 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061022221034.GE3093@redhat.com \
--to=davej@redhat.com \
--cc=amit2030@gmail.com \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox