Re: [patch] input: function call order in serio_exit()

Dmitry Torokhov
2006-10-23T03:15:51Z

On Sunday 22 October 2006 11:45, Németh Márton wrote:
> Hi,
>
> the order of the bus registration and the kthread start was changed
> between linux kernel 2.6.17.11 and 2.6.18. The order is now first
> register the bus and then start the kthread. The serio_exit() left
> unchanged.
>
> I think that the order of the function calls in serio_exit() should also
> be changed: first stop the kthread and then unregister the bus.
>
> What do you think?
>

Hi,

It really does not matter - if bus is unregistered that means the there
are no drivers using it and so noone can submit new requests to kseriod.

I'd leave it as is.

--
Dmitry