public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andries Brouwer <Andries.Brouwer@cwi.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: Pekka J Enberg <penberg@cs.helsinki.fi>,
	Bryan Henderson <hbryan@us.ibm.com>,
	Andries Brouwer <aebr@win.tue.nl>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sct@redhat.com, adilger@clusterfs.com,
	linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net
Subject: Re: [PATCH] ext3: fsid for statvfs
Date: Mon, 23 Oct 2006 13:10:22 +0200	[thread overview]
Message-ID: <20061023111022.GA8408@apps.cwi.nl> (raw)
In-Reply-To: <20061010133636.6217a11b.akpm@osdl.org>

On Tue, Oct 10, 2006 at 01:36:36PM -0700, Andrew Morton wrote:
> On Tue, 10 Oct 2006 11:32:13 +0300 (EEST)
> Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> 
> > From: Pekka Enberg <penberg@cs.helsinki.fi>
> > 
> > Update ext3_statfs to return an FSID that is a 64 bit XOR of the 128 bit
> > filesystem UUID as suggested by Andreas Dilger.
> 
> Deja vu.  Gosh, has it really been four years?
> 
> Combatants cc'ed ;)

Ha, you have a memory. To me this seems infinitely long ago.
Google turned up some interesting discussions on dev_t, and the below exchange.

No, at first sight I have no objections to the suggested patch.
(Although I think that fsid is used only for doubtful purposes.)

Andries

-----
Andries Brouwer wrote:
> On Mon, Dec 09, 2002 at 02:15:12PM -0800, H. Peter Anvin wrote:
>
> > > The general idea is that f_fsid contains some random stuff such that
> > > the pair (f_fsid,ino) uniquely determines a file.
>
> > This, of course, is the exact POSIX definition of the st_dev part of
> > struct stat: (st_dev, st_ino) uniquely identifies the file.
>
> Yes, but the difference is that (st_dev, st_ino) only identifies
> the file within a single machine, and may stop working when you
> have NFS mounts.

      parent reply	other threads:[~2006-10-23 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10  8:32 [PATCH] ext3: fsid for statvfs Pekka J Enberg
2006-10-10 20:36 ` Andrew Morton
2006-10-11  7:41   ` Pekka Enberg
2006-10-11 16:11   ` Stephen C. Tweedie
2006-10-23 11:10   ` Andries Brouwer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061023111022.GA8408@apps.cwi.nl \
    --to=andries.brouwer@cwi.nl \
    --cc=adilger@clusterfs.com \
    --cc=aebr@win.tue.nl \
    --cc=akpm@osdl.org \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=hbryan@us.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox