From: Martin Waitz <tali@admingilde.org>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
torvalds@osdl.org, viro@ftp.linux.org.uk, hch@infradead.org,
jack@suse.cz
Subject: Re: [PATCH 01 of 23] VFS: change struct file to use struct path
Date: Mon, 23 Oct 2006 13:47:36 +0200 [thread overview]
Message-ID: <20061023114736.GA15167@admingilde.org> (raw)
In-Reply-To: <20061021072807.GF30620@filer.fsl.cs.sunysb.edu>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
hoi :)
On Sat, Oct 21, 2006 at 03:28:07AM -0400, Josef Sipek wrote:
> > why?
>
> It's little cleaner than having two pointers. In general, there is a number
> of users of dentry-vfsmount pairs in the kernel, and struct path nicely
> wraps it.
Sure, but you can split the patch up:
First, change struct file and introduce the #defines so that everything
still works as before.
If this is accepted upstream, you can start to move other kernel
code to use the new names.
If all active trees have finally moved to only use the new name,
then you can remove the #define.
--
Martin Waitz
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-10-23 11:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 6:17 [PATCH 00 of 23] struct file: Use struct path Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 01 of 23] VFS: change struct file to use " Josef Jeff Sipek
2006-10-21 7:22 ` Andrew Morton
2006-10-21 7:28 ` Josef Sipek
2006-10-23 11:47 ` Martin Waitz [this message]
2006-10-24 9:03 ` Josef Sipek
2006-10-21 6:17 ` [PATCH 02 of 23] sysfs: change uses of f_{dentry, vfsmnt} to use f_path Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 03 of 23] proc: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 04 of 23] ext2: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 05 of 23] ext3: " Josef Jeff Sipek
2006-10-21 12:51 ` Robert Peterson
2006-10-21 18:26 ` Josef Sipek
2006-10-21 6:17 ` [PATCH 06 of 23] ext4: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 07 of 23] fat: change uses of f_{dentry,vfsmnt} " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 08 of 23] isofs: change uses of f_{dentry, vfsmnt} " Josef Jeff Sipek
2006-10-21 23:13 ` James Morris
2006-10-22 0:11 ` Linus Torvalds
2006-10-21 6:17 ` [PATCH 09 of 23] nfs: change uses of f_{dentry,vfsmnt} " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 10 of 23] nfsd: change uses of f_{dentry, vfsmnt} " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 11 of 23] ntfs: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 12 of 23] i386: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 13 of 23] x86_64: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 14 of 23] kernel: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 15 of 23] mm: change uses of f_{dentry,vfsmnt} " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 16 of 23] 9p: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 17 of 23] affs: change uses of f_{dentry, vfsmnt} " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 18 of 23] autofs: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 19 of 23] autofs4: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 20 of 23] configfs: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 21 of 23] cifs: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 22 of 23] ecryptfs: " Josef Jeff Sipek
2006-10-21 6:17 ` [PATCH 23 of 23] xfs: change uses of f_{dentry,vfsmnt} " Josef Jeff Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061023114736.GA15167@admingilde.org \
--to=tali@admingilde.org \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jsipek@fsl.cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox