* [PATCH] sys_setpgid: eliminate unnecessary do_each_task_pid(PIDTYPE_PGID)
@ 2006-10-23 17:51 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2006-10-23 17:51 UTC (permalink / raw)
To: Andrew Morton
Cc: Cedric Le Goater, Eric W. Biederman, Jeff Dike, linux-kernel
On top of add-process_session-helper-routine.patch
All tasks in the process group have the same sid, we don't need to iterate
them all to check that the caller of sys_setpgid() doesn't change its session.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- rc2-mm2/kernel/sys.c~ 2006-10-22 19:28:17.000000000 +0400
+++ rc2-mm2/kernel/sys.c 2006-10-23 20:35:56.000000000 +0400
@@ -1398,16 +1398,13 @@ asmlinkage long sys_setpgid(pid_t pid, p
goto out;
if (pgid != pid) {
- struct task_struct *p;
+ struct task_struct *g =
+ find_task_by_pid_type(PIDTYPE_PGID, pgid);
- do_each_task_pid(pgid, PIDTYPE_PGID, p) {
- if (process_session(p) == process_session(group_leader))
- goto ok_pgid;
- } while_each_task_pid(pgid, PIDTYPE_PGID, p);
- goto out;
+ if (!g || process_session(g) != process_session(group_leader))
+ goto out;
}
-ok_pgid:
err = security_task_setpgid(p, pgid);
if (err)
goto out;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-10-23 17:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-23 17:51 [PATCH] sys_setpgid: eliminate unnecessary do_each_task_pid(PIDTYPE_PGID) Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).