Re: Battery class driver.

Benjamin Herrenschmidt
2006-10-24T03:41:49Z

> No, I think the distinction between batteries and ac_adapter is large
> enough to have different classes of devices. You may have many
> batteries, but you'll only ever have one ac_adapter. I'm not sure it's
> an obvious abstraction to make.

No you won't :) You can have several power supplies, you can have UPS
too, and limited power budget depending on the "status" of these things
(for example, on some blades, we slow things down when one of the power
supply fails to limit our load on the remaining one(s), though that's
currently done outside of linux).

Ben.

> > > Comments?
>
> How are battery change notifications delivered to userspace? I know acpi
> is using the input layer for buttons in the future (very sane IMO), so
> using sysfs events for each property changing would probably be nice.
>
> Comments on your patch:
>
> > +#define BAT_INFO_TEMP2 (2) /* °C/1000 */
> Temperature expressed in degrees C/1000? - what if the temperature goes
> below 0? What about just using mK (kelvin / 1000) - I don't know what is
> used in the kernel elsewhere tho. Also, are you allowed the ° sign in
> kernel source now?
>
> > +#define BAT_INFO_CURRENT (6) /* mA */
> Can't this also be expressed in mW according to the ACPI spec?
>
> > +#define BAT_STAT_FIRE (1<<7)
> I know there is precedent for "FIRE" but maybe CRITICAL or DANGER might
> be better chosen words. We can reserve the word FIRE for when the faulty
> battery really is going to explode...
>
> Richard.
>
> > > commit 42fe507a262b2a2879ca62740c5312778ae78627
> > > Author: David Woodhouse <dwmw2@infradead.org>
> > > Date: Mon Oct 23 18:14:54 2006 +0100
> > >
> > > [BATTERY] Add support for OLPC battery
> > >
> > > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> > >
> > > commit 6cbec3b84e3ce737b4217788841ea10a28a5e340
> > > Author: David Woodhouse <dwmw2@infradead.org>
> > > Date: Mon Oct 23 18:14:14 2006 +0100
> > >
> > > [BATTERY] Add initial implementation of battery class
> > >
> > > I really don't like the sysfs interaction, and I don't much like the
> > > internal interaction with the battery drivers either. In fact, there
> > > isn't much I _do_ like, but it's good enough as a straw man.
> > >
> > > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>