From: "Luck, Tony" <tony.luck@intel.com>
To: Russ Anderson <rja@sgi.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] Mixed Madison and Montecito system support
Date: Mon, 23 Oct 2006 13:56:43 -0700 [thread overview]
Message-ID: <20061023205643.GA13990@intel.com> (raw)
In-Reply-To: <200610130325.k9D3PwIo17962445@clink.americas.sgi.com>
Cc: linux-kernel for generic bit of this change. Rest of patch was
posted to linux-ia64: http://marc.theaimsgroup.com/?l=linux-ia64&m=116070997529216&w=2
On Thu, Oct 12, 2006 at 10:25:58PM -0500, Russ Anderson wrote:
> int sched_create_sysfs_power_savings_entries(struct sysdev_class *cls)
> {
> - int err = 0;
> + int err = 0, c;
>
> #ifdef CONFIG_SCHED_SMT
> - if (smt_capable())
> - err = sysfs_create_file(&cls->kset.kobj,
> + for_each_online_cpu(c)
> + if (smt_capable(c)) {
> + err = sysfs_create_file(&cls->kset.kobj,
> &attr_sched_smt_power_savings.attr);
> + break;
> + }
> #endif
What if you booted an all-Madison system, and then hot-plugged some
Montecitos later? Either we'd need the hotplug cpu code to run through
this routine again to re-test whether any cpu has multi-thread support
(it doesn't look like it does that now).
Or perhaps it would be simpler to dispense with this test and always
call sysfs_create_file() here (still inside CONFIG_SCHED_SMT) so that
the hook is always present to tune the scheduler (even if it may be
ineffective on a no-smt system)?
-Tony
next parent reply other threads:[~2006-10-23 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610130325.k9D3PwIo17962445@clink.americas.sgi.com>
2006-10-23 20:56 ` Luck, Tony [this message]
2006-10-25 0:56 ` [patch] Mixed Madison and Montecito system support Russ Anderson
2006-10-25 23:42 ` Siddha, Suresh B
2006-10-26 16:44 ` Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061023205643.GA13990@intel.com \
--to=tony.luck@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox