* [PATCH] add-process_session-helper-routine-deprecate-old-field-tidy
@ 2006-10-24 18:36 Oleg Nesterov
2006-11-07 16:12 ` Cedric Le Goater
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2006-10-24 18:36 UTC (permalink / raw)
To: Andrew Morton; +Cc: Cedric Le Goater, linux-kernel
Cedric Le Goater wrote:
>
> - .session = 1, \
> + .tty_old_pgrp = 0, \
> + { .session = 1}, \
Any reason to initialize .tty_old_pgrp explicitly? This gives a false
positive from grep...
--- rc2-mm2/include/linux/init_task.h~ 2006-10-22 19:28:17.000000000 +0400
+++ rc2-mm2/include/linux/init_task.h 2006-10-24 22:24:04.000000000 +0400
@@ -66,8 +66,7 @@
.cpu_timers = INIT_CPU_TIMERS(sig.cpu_timers), \
.rlim = INIT_RLIMITS, \
.pgrp = 1, \
- .tty_old_pgrp = 0, \
- { .__session = 1}, \
+ { .__session = 1 }, \
}
extern struct nsproxy init_nsproxy;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] add-process_session-helper-routine-deprecate-old-field-tidy
2006-10-24 18:36 [PATCH] add-process_session-helper-routine-deprecate-old-field-tidy Oleg Nesterov
@ 2006-11-07 16:12 ` Cedric Le Goater
0 siblings, 0 replies; 2+ messages in thread
From: Cedric Le Goater @ 2006-11-07 16:12 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Andrew Morton, linux-kernel
Oleg Nesterov wrote:
> Cedric Le Goater wrote:
>> - .session = 1, \
>> + .tty_old_pgrp = 0, \
>> + { .session = 1}, \
>
> Any reason to initialize .tty_old_pgrp explicitly? This gives a false
> positive from grep...
it helps some version of gcc to find the anonymous union. I need to dig
this issue a little bit more.
thanks,
C.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-07 16:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-24 18:36 [PATCH] add-process_session-helper-routine-deprecate-old-field-tidy Oleg Nesterov
2006-11-07 16:12 ` Cedric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).