Re: [2.6.19 patch] drivers/ide/pci/generic.c: re-add the __setup("all-generic-ide",...)

Adrian Bunk
2006-10-19T16:13:42Z

On Thu, Oct 19, 2006 at 09:07:41AM -0700, Randy Dunlap wrote:
> On Thu, 19 Oct 2006 17:26:51 +0200 Adrian Bunk wrote:
>...
> > --- linux-2.6/drivers/ide/pci/generic.c.old 2006-10-19 16:35:15.000000000 +0200
> > +++ linux-2.6/drivers/ide/pci/generic.c 2006-10-19 16:46:21.000000000 +0200
> > @@ -40,6 +40,19 @@
> >
> > static int ide_generic_all; /* Set to claim all devices */
> >
> > +/*
> > + * the module_param_named() was added for the modular case
> > + * the __setup() is left as compatibility for existing setups
> > + */
> > +#ifndef MODULE
> > +static int __init ide_generic_all_on(char *unused)
> > +{
> > + ide_generic_all = 1;
> > + printk(KERN_INFO "IDE generic will claim all unknown PCI IDE storage controllers.");
> > + return 1;
> > +}
> > +__setup("all-generic-ide", ide_generic_all_on);
> > +#endif
> > module_param_named(all_generic_ide, ide_generic_all, bool, 0444);
> > MODULE_PARM_DESC(all_generic_ide, "IDE generic will claim all unknown PCI IDE storage controllers.");
>
> Missing update to Documentation/kernel-parameters.txt ?
> (maybe it's been missing forever?)

It's been missing forever.

I'm not sure whether documenting it now where it's deprecated and nearly
dead makes sense..

> ~Randy

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed