Re: r8169 mac address change (was Re: [0/3] 2.6.19-rc2: known regressions)

Francois Romieu
2006-10-31T23:15:08Z

Guennadi Liakhovetski <g.liakhovetski@gmx.de> :
[...]
> Well, with that one I booted 3 times, all 3 times it worked. I'll leave it

Thanks.

Let's cross fingers.

> in to see if it ever fails. So, what does it tell us about the
> set_mac_address thing?

It tells nothing more about the set_mac_address thing. If people need
MAC address change support, I can surely hack something and keep a
patch for future reference. Imho it is anything but 2.6.19 material
though.

The patch that I sent to you on 2006/10/29 was enough to fix the link
detection issues experienced with the 0x8136 chipset (1. Darren Salt
on netdev {25/26/31}/08/2006 and {21/22}/10/2006, 2. Syed Azam on BZ,
see http://bugzilla.kernel.org/show_bug.cgi?id=7378).

Your computer was good at spotting issues with the MAC address stuff,
so it was the perfect candidate to test pending fixes for different
problems. As you noticed, it was not exactly safe to feed the MII
control register with some potentially uninitialized stuff, whence
the patch from yesterday.

It remains to be seen if:
- it still does the job for the 0x8136
- it does not induce new regressions in existing 8169

o Darren and Syed, are your 0x8136 still happy with the patch
0001-r8169-perform-a-PHY-reset-before-any-other-operation-at-boot-time.txt
at http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.19-rc4/r8169
on top of 2.6.19-rc4 ?

o Darren, still ok to keep your S-o-b in it ?

o Could the r8169 users out there check that the same patch does not add
new regressions to their favorite 2.6.19-rc4 ?

o Lennert, can you apply the two patches
- 0001-r8169-perform-a-PHY-reset-before-any-other-operation-at-boot-time.txt
- 0002-r8169-more-magic.txt
at http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.19-rc4/r8169 against
2.6.19-rc4 (2.6.19-rc4 reverted the MAC address changes) and see if the
n2100 board still needs to remove the SYSErr handler ?

--
Ueimor