Re: [linux-usb-devel] [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

Adrian Bunk
2006-10-31T18:07:16Z

On Tue, Oct 31, 2006 at 10:40:15AM -0700, David Brownell wrote:
>
> > > +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE)
> > > +#define HAVE_MII
> > >...
> >
> > This seems to cause a CONFIG_USB_USBNET=y, CONFIG_MII=m breakage
> > (as already described earlier in this thread)?
>
> Well, "alluded to" not described. Fixable by the equivalent of
>
> config USB_USBNET
> ...
> depends on MII if MII != n
>
> except that Kconfig doesn't comprehend conditionals like that.

You can express this in Kconfig:
depends MII || MII=n

But my suggestion was:
#if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE))

Or simply select MII ...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed