* [PATCH] fix RARP ic_servaddr breakage
@ 2006-10-24 21:10 Al Viro
2006-10-24 22:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2006-10-24 21:10 UTC (permalink / raw)
To: Linus Torvalds; +Cc: davem, linux-kernel
memcpy 4 bytes to address of auto unsigned long variable followed
by comparison with u32 is a bloody bad idea.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
net/ipv4/ipconfig.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index f8ce847..955a07a 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -420,7 +420,7 @@ ic_rarp_recv(struct sk_buff *skb, struct
{
struct arphdr *rarp;
unsigned char *rarp_ptr;
- unsigned long sip, tip;
+ u32 sip, tip;
unsigned char *sha, *tha; /* s for "source", t for "target" */
struct ic_device *d;
--
1.4.2.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix RARP ic_servaddr breakage
2006-10-24 21:10 [PATCH] fix RARP ic_servaddr breakage Al Viro
@ 2006-10-24 22:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-10-24 22:18 UTC (permalink / raw)
To: viro; +Cc: torvalds, linux-kernel
From: Al Viro <viro@ftp.linux.org.uk>
Date: Tue, 24 Oct 2006 22:10:27 +0100
> memcpy 4 bytes to address of auto unsigned long variable followed
> by comparison with u32 is a bloody bad idea.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Applied, good spotting Al.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-24 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-24 21:10 [PATCH] fix RARP ic_servaddr breakage Al Viro
2006-10-24 22:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox