From: Joe Korty <joe.korty@ccur.com>
To: mpm@selenic.com
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] strange work_notifysig code since 2.6.16
Date: Tue, 24 Oct 2006 19:19:21 -0400 [thread overview]
Message-ID: <20061024231921.GA25130@tsunami.ccur.com> (raw)
tree 9b5daef5280800a0006343a17f63072658d91a1d is surely wrong.
[PATCH] Make vm86 support optional
Jan 8, 2006, tree first appears in 2.6.16
If the branch to work_notifysig_86 is taken and CONFIG_VM86=n,
then entry.S drops into unrelated assembly code.
The branch to work_notifysig_v86, a few lines above the patch, says:
"returning to kernel-space or vm86-space"
which implies if vm86-space isn't being supported we still need the
branch & jumped-to code in order to handle the kernel case.
However, I don't understand this area all that well, so take this patch
as more of an indication of a possible problem area than as a true fix.
Signed-off-by: Joe Korty <joe.korty@ccur.com>
Index: 2.6.18.1/arch/i386/kernel/entry.S
===================================================================
--- 2.6.18.1.orig/arch/i386/kernel/entry.S 2006-09-19 23:42:06.000000000 -0400
+++ 2.6.18.1/arch/i386/kernel/entry.S 2006-10-24 19:08:36.000000000 -0400
@@ -457,7 +457,6 @@
ALIGN
work_notifysig_v86:
-#ifdef CONFIG_VM86
pushl %ecx # save ti_flags for do_notify_resume
CFI_ADJUST_CFA_OFFSET 4
call save_v86_state # %eax contains pt_regs pointer
@@ -467,7 +466,6 @@
xorl %edx, %edx
call do_notify_resume
jmp resume_userspace_sig
-#endif
# perform syscall exit tracing
ALIGN
next reply other threads:[~2006-10-24 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 23:19 Joe Korty [this message]
2006-10-25 5:48 ` [PATCH] strange work_notifysig code since 2.6.16 Matt Mackall
2006-10-25 14:29 ` Joe Korty
2006-10-25 19:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061024231921.GA25130@tsunami.ccur.com \
--to=joe.korty@ccur.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox