Re: [PATCH] lkdtm: cleanup headers and module_param/MODULE_PARM_DESC

[Ankita Garg <ankita@in.ibm.com>]

Hi,

>  #include <linux/kernel.h>
> +#include <linux/fs.h>
>  #include <linux/module.h>
> +#include <linux/buffer_head.h>
>  #include <linux/kprobes.h>
> -#include <linux/kallsyms.h>
> +#include <linux/list.h>
>  #include <linux/init.h>
> -#include <linux/irq.h>
>  #include <linux/interrupt.h>
> +#include <linux/hrtimer.h>
>  #include <scsi/scsi_cmnd.h>

Why does the module require fs.h, hrtimer.h, list.h and buffer_head.h? It works fine for me without these header files. I do not get any gcc warning. Moreover, I found that even init.h and interrupt.h are also not required.
  
> +MODULE_PARM_DESC(cpoint_name, " Crash Point, where kernel is to be crashed");
> +module_param(cpoint_type, charp, 0644);
> +MODULE_PARM_DESC(cpoint_type, " Crash Point Type, action to be taken on "\
> +				"hitting the crash point");
> +module_param(cpoint_count, int, 0644);
> +MODULE_PARM_DESC(cpoint_count, " Crash Point Count, number of times the "\
                                                                            ^^not required now!
> +				"crash point is to be hit to trigger action");
>  

Thanks for fixing the typo.
 
> ---
> ~Randy

-- 
Ankita Garg 
Linux Technology Center