From: Andrew Morton <akpm@osdl.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
iss_storagedev@hp.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH cciss: fix printk format warning
Date: Thu, 26 Oct 2006 16:31:52 -0700 [thread overview]
Message-ID: <20061026163152.9fcdd8fc.akpm@osdl.org> (raw)
In-Reply-To: <ada64e67jhf.fsf@cisco.com>
On Thu, 26 Oct 2006 16:19:56 -0700
Roland Dreier <rdreier@cisco.com> wrote:
> > > if (*total_size != (__u32) 0)
> >
> > Why is cciss_read_capacity casting *total_size to u32?
>
> It's not -- it's actually casting 0 to __32
bah.
> -- there's no cast on the
> *total_size side of the comparison. However that just makes the cast
> look even fishier.
yup, it's harmless. Just something which was put in there to entertain passers-by.
prev parent reply other threads:[~2006-10-26 23:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 4:46 [PATCH cciss: fix printk format warning Randy Dunlap
2006-10-24 13:25 ` Miller, Mike (OS Dev)
2006-10-26 23:02 ` Andrew Morton
2006-10-26 23:19 ` Roland Dreier
2006-10-26 23:29 ` Randy Dunlap
2006-10-26 23:35 ` Randy Dunlap
2006-10-26 23:49 ` Roland Dreier
2006-10-26 23:53 ` Randy Dunlap
2006-10-27 13:11 ` Cameron, Steve
2006-10-27 15:07 ` Randy Dunlap
2006-10-27 15:15 ` Miller, Mike (OS Dev)
2006-10-26 23:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061026163152.9fcdd8fc.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox