Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

Adrian Bunk
2006-11-03T02:27:27Z

On Thu, Nov 02, 2006 at 12:29:12PM -0800, David Brownell wrote:
> On Wednesday 01 November 2006 11:15 pm, Greg KH wrote:
>
> > Argh, there were just too many different versions of these patches
> > floating around. Can you resend the final versions please?
>
> This should replace BOTH of Randy's patches. It addresses all the
> issues I've heard raised, and resolves the regresssion introduced
> when adding the mcs7830 minidriver.

It seems to lack the "select MII" at the USB_RTL8150 option that was in
Randy's first patch?

> - Dave
>...
> --- at91.orig/drivers/usb/net/Kconfig 2006-11-02 10:58:49.000000000 -0800
> +++ at91/drivers/usb/net/Kconfig 2006-11-02 12:10:13.000000000 -0800
> @@ -92,8 +92,13 @@ config USB_RTL8150
> To compile this driver as a module, choose M here: the
> module will be called rtl8150.
>
> +config USB_USBNET_MII
> + tristate
> + default n
> +
> config USB_USBNET
> tristate "Multi-purpose USB Networking Framework"
> + select MII if USBNET_MII != n
> ---help---
> This driver supports several kinds of network links over USB,
> with "minidrivers" built around a common network driver core
> @@ -129,7 +134,7 @@ config USB_NET_AX8817X
> tristate "ASIX AX88xxx Based USB 2.0 Ethernet Adapters"
> depends on USB_USBNET && NET_ETHERNET
> select CRC32
> - select MII
> + select USB_USBNET_MII
> default y
> help
> This option adds support for ASIX AX88xxx based USB 2.0
> @@ -210,6 +215,7 @@ config USB_NET_PLUSB
> config USB_NET_MCS7830
> tristate "MosChip MCS7830 based Ethernet adapters"
> depends on USB_USBNET
> + select USB_USBNET_MII
> help
> Choose this option if you're using a 10/100 Ethernet USB2
> adapter based on the MosChip 7830 controller. This includes
> Index: at91/drivers/usb/net/usbnet.c
> ===================================================================
> --- at91.orig/drivers/usb/net/usbnet.c 2006-11-02 10:58:49.000000000 -0800
> +++ at91/drivers/usb/net/usbnet.c 2006-11-02 11:09:29.000000000 -0800
>...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed