Re: [RFC: 2.6.19 patch] let PCI_MULTITHREAD_PROBE depend on BROKEN

Pavel Machek
2006-10-27T17:22:25Z

Hi!

> > > > > PCI_MULTITHREAD_PROBE is an interesting feature, but in it's current
> > > > > state it seems to be more of a trap for users who accidentally
> > > > > enable it.
> > > > >
> > > > > This patch lets PCI_MULTITHREAD_PROBE depend on BROKEN for 2.6.19.
> > > > >
> > > > > The intention is to get this patch reversed in -mm as soon as it's in
> > > > > Linus' tree, and reverse it for 2.6.20 or 2.6.21 after the fallout of
> > > > > in-kernel problems PCI_MULTITHREAD_PROBE causes got fixed.
> > > >
> > > > People who enable features clearly marked as EXPERIMENTAL deserve what
> > > > they get, IMO.
> > >
> > > It's not the impact on "people" which is of concern - it's the impact on
> > > kernel developers - specifically those who spend time looking at bug
> > > reports :(
> >
> > Either it is broken and should be removed, or is barely working and
> > should be fixed. If Greg wants to take bug reports then it can stay.
>
> I want to keep taking bug reports.
>
> I've found only 1 real bug from all of this. The pci MSI initialization
> issue. It's on my queue of things to fix. Andrew has also sent me
> another "interesting" patch about making sure devices are found by the
> time we hit another init level which I'll see about adding too.

And the swsusp vs. SATA issue? Currently, SATA can be initialized
after swsusp, leading to swsusp not finding its image and failing...

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html