Re: [PATCH] Use extents for recording what swap is allocated.

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > > > > And now, can you do same computation assuming the swap allocator goes
> > > > > > completely crazy, and free space is in 1-page chunks?
> > > > > 
> > > > > The worst case is 3 * sizeof(unsigned long) *
> > > > > number_of_swap_extents_allocated bytes.
> > > > 
> > > > Okay, so if we got 4GB of swap space, thats 1MB swap pages, worst case
> > > > is you have one extent per page, on x86-64 that's 24MB. +kmalloc
> > > > overhead, I assume?
> > > 
> > > Sounds right.
> > 
> > Ok, 24-50MB per 4GB of swap space is not _that_ bad...
> 
> Other way round: 12MB for x86, 24 for x86_64 is the worst case.
> Actually, come to think of it, that would be for 8GB of swap space. The
> worst case would require every page of swap to be alternately free and
> allocated, so for 4GB you'd only have 2GB of swap allocated = 1/2 the
> number of extents and half the memory requirements.

Ok, I was trying to do the ballpark estimate.

> > > You're not going to respond to the other bit of my reply? I was
> > > beginning to think you were being more reasonable this time. Oh well.
> > 
> > Rafael likes your code, and that's a big plus, but do you have to
> > insult me?!
> 
> Pavel, I never seek to insult you and I'm sorry that you felt insulted
> by my comment. In this case, I was expressing frustration at the fact
> that you seemed to be (in my opinion anyway) being unreasonable in
> completely ignoring and deleting my points about the likelihood of this
> worse case scenario, and instead focusing on calculating the

Well, deleting the points meant I mostly agree with them. But knowing
how bad worst case is is still interesting (I do not think future swap
allocator may not suddenly start making lots of small holes, or
something). Anyway, that patch is probably okay...

> How about if we just call it quits and try to be nice to each other?

Quits.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html