From: Randy Dunlap <randy.dunlap@oracle.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: jesper.juhl@gmail.com, torvalds <torvalds@osdl.org>,
akpm <akpm@osdl.org>
Subject: Re: [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485
Date: Fri, 27 Oct 2006 16:21:16 -0700 [thread overview]
Message-ID: <20061027162116.deb9dafe.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200610272259.k9RMx3cq030980@hera.kernel.org>
On Fri, 27 Oct 2006 22:59:03 GMT Linux Kernel Mailing List wrote:
> commit efbfe96c5d839c367249bf1cd53249716450c0a2
> tree 36a1a7d72586a2f8fd25feb225cd4e627cd275b3
> parent 735a7ffb739b6efeaeb1e720306ba308eaaeb20e
> author Jesper Juhl <jesper.juhl@gmail.com> 1161984287 +0200
> committer Linus Torvalds <torvalds@g5.osdl.org> 1161988491 -0700
>
> [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485
>
> Add description of 'raw' in comments for
> drivers/mtd/nand/nand_base.c::nand_write_page_syndrome() so 'make xmldocs'
> will not spew a warning at us.
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> drivers/mtd/nand/nand_base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index baece61..41bfcae 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -1479,6 +1479,7 @@ static void nand_write_page_syndrome(str
> * @buf: the data to write
> * @page: page number to write
> * @cached: cached programming
> + * @raw: use _raw version of write_page
> */
> static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
> const uint8_t *buf, int page, int cached, int raw)
> -
Hi Jesper,
I'm still seeing a kernel-doc warning in include/linux/mtd/nand.h.
Do you not see it also?
Patch is here:
http://marc.theaimsgroup.com/?l=linux-mm-commits&m=116189778426861&w=2
---
~Randy
next parent reply other threads:[~2006-10-27 23:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610272259.k9RMx3cq030980@hera.kernel.org>
2006-10-27 23:21 ` Randy Dunlap [this message]
2006-10-28 17:07 ` [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485 Jesper Juhl
[not found] <200610260143.24694.jesper.juhl@gmail.com>
2006-10-26 5:27 ` Thomas Gleixner
2006-10-27 21:24 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061027162116.deb9dafe.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox