public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: thockin@hockin.org
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: Lee Revell <rlrevell@joe-job.com>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>,
	john stultz <johnstul@us.ibm.com>
Subject: Re: AMD X2 unsynced TSC fix?
Date: Fri, 27 Oct 2006 16:04:58 -0700	[thread overview]
Message-ID: <20061027230458.GA27976@hockin.org> (raw)
In-Reply-To: <20061027201820.GA8394@dreamland.darkstar.lan>

On Fri, Oct 27, 2006 at 10:18:20PM +0200, Luca Tettamanti wrote:
> Lee Revell <rlrevell@joe-job.com> ha scritto:
> > Someone recently pointed out to me that a Windows "CPU driver update"
> > supplied by AMD fixes the unsynced TSC problem on dual core AMD64
> > systems.
> [...]
> > other incorrect timing effects that these applications may experience on
> > dual-core processor systems, by periodically adjusting the core
> > time-stamp-counters, so that they are synchronized."
> > 
> > What are the chances of Linux getting a similar fix?
> 
> Zero? ;)

Wrong.  We have a fix that has been under serious testing for a long time.

> There's always a window where the TSCs are not in sync (and userspace may
> see a non-monotonic counter); furthermore when C'n'Q is active TSCs
> aren't updated at a fixed frequency, userspace cannot use TSC for timing
> anyway.

Wrong, too.  We have a patch that will be coming SOON (trust me, I am
pushing hard for the author to publish it).  With this patch applied you
should never see the TSC go backwards.  Period.  It should be monotonic
(to userspace, kernel rdtsc calls can still be wrong).  CPUs should stay
very nearly in sync (again, to userspace).  The overhead of this patch is
pretty minimal and costs nothing unless you actually read the TSC.

The catch is that, while it is monotonic, it is not guaranteed to be
perfectly linear.  For many applications, this will be good enough.  Time
will always move forward, and you won't be subject to the weird HZ
granularity gettimeofday that unsynced TSCs can show.

I'm BCCing the author to poke him more publicly.

Tim

  reply	other threads:[~2006-10-27 23:05 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-27 17:15 AMD X2 unsynced TSC fix? Lee Revell
2006-10-27 20:18 ` Luca Tettamanti
2006-10-27 23:04   ` thockin [this message]
2006-10-28  0:00     ` Luca Tettamanti
2006-10-28  0:17       ` Lee Revell
2006-10-28  2:46       ` thockin
2006-10-28  3:59         ` Andi Kleen
2006-10-28  6:32           ` thockin
2006-10-28  9:14           ` Vojtech Pavlik
2006-10-28 18:22           ` Lee Revell
2006-10-28 19:57             ` Vojtech Pavlik
2006-10-28 22:54               ` thockin
2006-10-28  1:04     ` Andi Kleen
2006-10-28  3:28       ` Lee Revell
2006-10-28  5:28         ` Willy Tarreau
2006-10-28 18:08           ` Lee Revell
2006-10-28 19:14             ` thockin
2006-10-30 17:22             ` Langsdorf, Mark
2006-10-28 18:37           ` Andi Kleen
2006-10-28 19:15             ` Willy Tarreau
2006-10-28 19:18               ` thockin
2006-10-28 19:32                 ` Willy Tarreau
2006-10-28 19:42                   ` thockin
2006-10-28 20:16                     ` Willy Tarreau
2006-10-28 19:33               ` Andi Kleen
2006-10-28 20:04                 ` Willy Tarreau
2006-10-28 20:11                   ` Andi Kleen
2006-10-28 20:36                     ` Willy Tarreau
2006-10-29  1:28                 ` Lee Revell
2006-10-28 21:00               ` Lee Revell
2006-10-31 11:12           ` Pádraig Brady
2006-10-31 15:31             ` Willy Tarreau
2006-10-30 20:30     ` Christoph Lameter
2006-10-27 20:35 ` Andi Kleen
2006-10-27 20:41   ` Lee Revell
2006-10-27 21:48     ` Chris Friesen
2006-10-27 22:08       ` Lee Revell
2006-10-28  3:58         ` Sergio Monteiro Basto
2006-10-28  4:06           ` Andi Kleen
2006-10-28  4:22             ` Sergio Monteiro Basto
2006-10-30  3:10               ` Sergio Monteiro Basto
2006-10-30 15:23                 ` Andi Kleen
     [not found]                   ` <1162253008.2999.9.camel@localhost.portugal>
2006-10-31  0:14                     ` Lee Revell
2006-10-31  0:25                       ` john stultz
2006-10-31  2:41                     ` Siddha, Suresh B
2006-10-31 15:05                       ` Sergio Monteiro Basto
2006-11-01  1:46                       ` Sergio Monteiro Basto
2006-11-01  2:44                         ` Siddha, Suresh B
2006-11-08  0:22                           ` Sergio Monteiro Basto
2006-11-08 19:53                             ` Thomas Gleixner
2006-11-09  0:39                               ` Sergio Monteiro Basto
2006-11-09  1:13                                 ` john stultz
2006-11-09  1:27                                   ` Sergio Monteiro Basto
2006-11-15  1:51                                   ` Sergio Monteiro Basto
     [not found]                                     ` <20061115193514.41C01102C011@mail.goron.de>
2006-11-16  1:38                                       ` Sergio Monteiro Basto
2006-11-16  1:45                                         ` Sergio Monteiro Basto
2006-10-28  6:35             ` thockin
2006-10-28  6:46               ` Andrew Morton
2006-10-28  6:49                 ` thockin
2006-10-28  7:13                   ` Andrew Morton
2006-10-28  7:25                     ` thockin
2006-10-28  9:46                   ` Andi Kleen
2006-10-28  9:45                 ` Andi Kleen
2006-10-28  9:48               ` Andi Kleen
2006-10-27 21:58 ` Friedrich Göpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061027230458.GA27976@hockin.org \
    --to=thockin@hockin.org \
    --cc=ak@suse.de \
    --cc=johnstul@us.ibm.com \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rlrevell@joe-job.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox