Re: [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled

Randy.Dunlap
2006-10-26T15:53:37Z

Adrian Bunk wrote:
> On Wed, Oct 25, 2006 at 04:58:58PM -0700, Randy Dunlap wrote:
>> ...
>> Build tested with CONFIG_MII=y, m, n.
>> ...
>> --- linux-2619-rc3-pv.orig/drivers/usb/net/usbnet.c
>> +++ linux-2619-rc3-pv/drivers/usb/net/usbnet.c
>> @@ -47,6 +47,12 @@
>>
>> #define DRIVER_VERSION "22-Aug-2005"
>>
>> +#if defined(CONFIG_MII) || defined(CONFIG_MII_MODULE)
>> +#define HAVE_MII 1
>> +#else
>> +#define HAVE_MII 0
>> +#endif
>> ...
>
> I'm too lame to test it, but I bet this will break with
> CONFIG_USB_USBNET=y, CONFIG_MII=m, and you'll actually need
>
> #if defined(CONFIG_MII) || (defined(CONFIG_MII_MODULE) && defined(MODULE))
>
> And then there's the question whether this amount of #ifdef's is
> actually worth avoiding the "select MII"...

Thanks, but that's OK, David posted a different patch for it.

--
~Randy