From: Jesper Juhl <jesper.juhl@gmail.com>
To: tglx@linutronix.de
Cc: LKML <linux-kernel@vger.kernel.org>,
"Steven J.Hill" <sjhill@realitydiluted.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485
Date: Fri, 27 Oct 2006 23:24:47 +0200 [thread overview]
Message-ID: <200610272324.48087.jesper.juhl@gmail.com> (raw)
In-Reply-To: <1161840423.31783.29.camel@localhost.localdomain>
On Thursday 26 October 2006 07:27, Thomas Gleixner wrote:
> On Thu, 2006-10-26 at 01:43 +0200, Jesper Juhl wrote:
> > 'make xmldocs' currently gives me this warning :
> >
> > Warning(/home/juhl/download/kernel/linux-2.6//drivers/mtd/nand/nand_base.c:1485): No description found for parameter 'raw'
> >
> > This patch silences the warning by adding a description for 'raw'
> >
> >
> > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
>
> ACK
> tglx
>
Thank you for the ACK Thomas.
Linus: Could you add this to your tree? I believe it's still appropriate even at -rc3 since it doesn't make any code changes but simply fix an annoying warning.
Patch included (again) below for your convenience :
Add description of 'raw' in comments for
drivers/mtd/nand/nand_base.c::nand_write_page_syndrome() so 'make xmldocs'
will not spew a warning at us.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
drivers/mtd/nand/nand_base.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index baece61..41bfcae 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -1479,6 +1479,7 @@ static void nand_write_page_syndrome(str
* @buf: the data to write
* @page: page number to write
* @cached: cached programming
+ * @raw: use _raw version of write_page
*/
static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
const uint8_t *buf, int page, int cached, int raw)
next prev parent reply other threads:[~2006-10-27 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610260143.24694.jesper.juhl@gmail.com>
2006-10-26 5:27 ` [PATCH] silence 'make xmldocs' warning by adding missing description of 'raw' in nand_base.c:1485 Thomas Gleixner
2006-10-27 21:24 ` Jesper Juhl [this message]
[not found] <200610272259.k9RMx3cq030980@hera.kernel.org>
2006-10-27 23:21 ` Randy Dunlap
2006-10-28 17:07 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610272324.48087.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sjhill@realitydiluted.com \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox