From: Andrew Morton <akpm@osdl.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq
Date: Mon, 30 Oct 2006 17:04:45 -0800 [thread overview]
Message-ID: <20061030170445.1dedce1e.akpm@osdl.org> (raw)
In-Reply-To: <20061030090231.GA27146@elte.hu>
On Mon, 30 Oct 2006 10:02:31 +0100
Ingo Molnar <mingo@elte.hu> wrote:
> * Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
>
> > Fix warning
> > arch/i386/kernel/io_apic.c: In function `create_irq':
> > arch/i386/kernel/io_apic.c:2420: warning: 'vector' might be used uninitialized in this function
>
> > @@ -2421,6 +2421,7 @@ int create_irq(void)
> > unsigned long flags;
> >
> > irq = -ENOSPC;
> > + vector = 0;
>
> NAK - the code is fine, and this is fixed in Jeff's gcc-warnings tree
> via annotation.
err, what gcc-warnings tree?
git+ssh://master.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git#gccbug
just does lots of initialise-to-zero thingies, doesn't have any special
annotation and doesn't fix io_apic.c.
next prev parent reply other threads:[~2006-10-31 1:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 21:04 [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq Stefan Richter
2006-10-30 9:02 ` Ingo Molnar
2006-10-31 1:04 ` Andrew Morton [this message]
2006-10-31 9:37 ` Ingo Molnar
2006-10-31 9:49 ` Andrew Morton
2006-10-31 11:15 ` Ingo Molnar
2006-10-31 19:09 ` Adrian Bunk
2006-11-09 10:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030170445.1dedce1e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox