From: Jeff Dike <jdike@addtoit.com>
To: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@yahoo.it>
Cc: Andrew Morton <akpm@osdl.org>,
user-mode-linux-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] uml ubd driver: var renames
Date: Mon, 30 Oct 2006 15:14:54 -0500 [thread overview]
Message-ID: <20061030201454.GA6079@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20061029192029.12292.15703.stgit@americanbeauty.home.lan>
On Sun, Oct 29, 2006 at 08:20:29PM +0100, Paolo 'Blaisorblade' Giarrusso wrote:
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
>
> and then call any "struct ubd" ubd_dev instead of dev, which doesn't
> make clear what we're treating (and no, it's not hungarian notation -
> not any more than calling all vm_area_struct vma or all inodes
> inode).
I can't say that I like this part of it. I don't see any alternate
interpretation of a variable called 'dev', and renaming it to
'ubd_dev' seems redundant, given that we are in the ubd driver.
Plus, this change sent a couple of lines over the 80-character
boundary.
Jeff
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2006-10-30 19:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 19:17 [PATCH 00/11] UBD driver little cleanups for 2.6.19 Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 01/11] uml ubd driver: allow using up to 16 UBD devices Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 02/11] uml ubd driver: document some struct fields Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 03/11] uml ubd driver: var renames Paolo 'Blaisorblade' Giarrusso
2006-10-30 20:14 ` Jeff Dike [this message]
2006-10-29 19:20 ` [PATCH 04/11] uml ubd driver: give better names to some functions Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 05/11] uml ubd driver: change ubd_lock to be a mutex Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 06/11] uml ubd driver: ubd_io_lock usage fixup Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 07/11] uml ubd driver: reformat ubd_config Paolo 'Blaisorblade' Giarrusso
2006-10-30 20:26 ` Jeff Dike
2006-10-30 20:30 ` Jeff Dike
2006-10-29 19:20 ` [PATCH 08/11] uml ubd driver: convert do_ubd to a boolean variable Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 09/11] uml ubd driver: use bitfields where possible Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 10/11] uml ubd driver: do not store error codes as ->fd Paolo 'Blaisorblade' Giarrusso
2006-10-29 19:20 ` [PATCH 11/11] uml ubd driver: various little changes Paolo 'Blaisorblade' Giarrusso
2006-10-29 20:02 ` [PATCH 00/11] UBD driver little cleanups for 2.6.19 Andrew Morton
2006-10-29 20:23 ` [uml-devel] " Blaisorblade
2006-10-30 20:36 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030201454.GA6079@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox