Re: [PATCH 2/6] eCryptfs: Hash code to new crypto API

Herbert Xu
2006-10-31T01:05:25Z

On Mon, Oct 30, 2006 at 05:35:29PM -0600, Michael Halcrow wrote:
>
> + crypto_hash_init(&desc);
> + crypto_hash_update(&desc, &sg, len);
> + crypto_hash_final(&desc, dst);

Whenever you do init+update+final, it's preferred that this be
changed to crypto_hash_digest as this enables future optimisations
to be made. For instance, some hardware can only handle a full
digest rather than a partial update.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt