public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	Evgeniy Dushistov <dushistov@mail.ru>
Subject: Re: [PATCH] fix UFS superblock alignment issues
Date: Tue, 31 Oct 2006 07:54:27 -0800	[thread overview]
Message-ID: <20061031075427.77ce2653.randy.dunlap@oracle.com> (raw)
In-Reply-To: <45476A36.2020405@redhat.com>

On Tue, 31 Oct 2006 09:22:30 -0600 Eric Sandeen wrote:

> Eric Sandeen wrote:
> > ufs2 fails to mount on x86_64, claiming bad magic.  This is because 
> > ufs_super_block_third's fs_un1 member is padded out by 4 bytes for
> > 8-byte alignment, pushing down the rest of the struct.
> > 
> > Forcing this to be packed solves it.  I took a quick look over
> > other on-disk structures and didn't immediately find other problems.
> > I was able to mount & ls a populated ufs2 filesystem w/ this change.
> 
> I should also mention that this seems to be a regression from
> 2.6.17->2.6.18, so perhaps it's a candidate for 2.6.18.x updates.

Please send it to stable@kernel.org .

---
~Randy

      reply	other threads:[~2006-10-31 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-31  3:46 [PATCH] fix UFS superblock alignment issues Eric Sandeen
2006-10-31 15:22 ` Eric Sandeen
2006-10-31 15:54   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061031075427.77ce2653.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=dushistov@mail.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox