* [patch]trivial: un-needed add-store operation wastes a few bytes
@ 2006-10-31 0:56 nkalmala
2006-10-31 10:01 ` Rolf Eike Beer
0 siblings, 1 reply; 2+ messages in thread
From: nkalmala @ 2006-10-31 0:56 UTC (permalink / raw)
To: trivial; +Cc: akpm, linux-kernel, nkalmala
Un-needed add-store operation wastes a few bytes.
8 bytes wasted with -O2, on a ppc.
Signed-off-by: nkalmala <nkalmala@gmail.com>
---
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b55bb35..bf2f6cf 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -853,7 +853,7 @@ again:
pcp = &zone_pcp(zone, cpu)->pcp[cold];
local_irq_save(flags);
if (!pcp->count) {
- pcp->count += rmqueue_bulk(zone, 0,
+ pcp->count = rmqueue_bulk(zone, 0,
pcp->batch, &pcp->list);
if (unlikely(!pcp->count))
goto failed;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch]trivial: un-needed add-store operation wastes a few bytes
2006-10-31 0:56 [patch]trivial: un-needed add-store operation wastes a few bytes nkalmala
@ 2006-10-31 10:01 ` Rolf Eike Beer
0 siblings, 0 replies; 2+ messages in thread
From: Rolf Eike Beer @ 2006-10-31 10:01 UTC (permalink / raw)
To: nkalmala; +Cc: trivial, akpm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
nkalmala wrote:
> Un-needed add-store operation wastes a few bytes.
> 8 bytes wasted with -O2, on a ppc.
>
> Signed-off-by: nkalmala <nkalmala@gmail.com>
Documentation/SubmittingPatches:
using your real name (sorry, no pseudonyms or anonymous contributions.)
Greetings,
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-31 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-31 0:56 [patch]trivial: un-needed add-store operation wastes a few bytes nkalmala
2006-10-31 10:01 ` Rolf Eike Beer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox