From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq
Date: Tue, 31 Oct 2006 12:15:02 +0100 [thread overview]
Message-ID: <20061031111502.GA21450@elte.hu> (raw)
In-Reply-To: <20061031014914.9af0dde9.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> > this is an initialize-to-zero annotation for a false-positive gcc
> > warning. If it's not in Jeff tree yet then it should be there ...
>
> hm, I wouldn't call that "annotation".
>
> Now, the
>
> #define SHUT_GCC_UP(x) = x
>
> ...
> int foo SHUT_GCC_UP(foo);
> ...
>
> (or whatever it was) trick was "annotation". A good way of doing it
> too, IMO.
hm, i thought Jeff's tree was doing that ...
we definitely do not want to hide these places. They both make the code
less readable (why initialize it to some value if that value is never
used) and they hide the problem from the GCC folks too.
Ingo
next prev parent reply other threads:[~2006-10-31 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 21:04 [PATCH 2.6.19-rc3] i386/io_apic: fix compiler warning in create_irq Stefan Richter
2006-10-30 9:02 ` Ingo Molnar
2006-10-31 1:04 ` Andrew Morton
2006-10-31 9:37 ` Ingo Molnar
2006-10-31 9:49 ` Andrew Morton
2006-10-31 11:15 ` Ingo Molnar [this message]
2006-10-31 19:09 ` Adrian Bunk
2006-11-09 10:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061031111502.GA21450@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox