From: Adrian Bunk <bunk@stusta.de>
To: per.liden@ericsson.com, jon.maloy@ericsson.com,
allan.stephens@windriver.com
Cc: tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] net/tipc/port.c: fix NULL dereference
Date: Wed, 1 Nov 2006 01:40:37 +0100 [thread overview]
Message-ID: <20061101004037.GZ27968@stusta.de> (raw)
The correct order is: NULL check before dereference
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/net/tipc/port.c.old 2006-11-01 00:37:58.000000000 +0100
+++ linux-2.6/net/tipc/port.c 2006-11-01 00:38:27.000000000 +0100
@@ -1136,11 +1136,12 @@
int res = -EINVAL;
p_ptr = tipc_port_lock(ref);
+ if (!p_ptr)
+ return -EINVAL;
+
dbg("tipc_publ %u, p_ptr = %x, conn = %x, scope = %x, "
"lower = %u, upper = %u\n",
ref, p_ptr, p_ptr->publ.connected, scope, seq->lower, seq->upper);
- if (!p_ptr)
- return -EINVAL;
if (p_ptr->publ.connected)
goto exit;
if (seq->lower > seq->upper)
next reply other threads:[~2006-11-01 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 0:40 Adrian Bunk [this message]
2006-11-01 0:59 ` [2.6 patch] net/tipc/port.c: fix NULL dereference David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101004037.GZ27968@stusta.de \
--to=bunk@stusta.de \
--cc=allan.stephens@windriver.com \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=per.liden@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox