public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda Sandonis <maxextreme@gmail.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH update6] drivers: add LCD support
Date: Wed, 1 Nov 2006 01:40:57 +0000	[thread overview]
Message-ID: <20061101014057.454c4f43.maxextreme@gmail.com> (raw)

Andrew, here it is the coding style fixes. Thanks you.

I think the driver is getting ready for freeze until
2.6.20-rc1 (if anyone sees something wrong), so I will
try to send just minor fixes like this.

After that, in the future, I will work on the Paulo Marques'
idea to reduce CPU waste even more if possible.
---

 - Minor coding style fixes

 Documentation/auxdisplay/cfag12864b-example.c |    4 ++--
 drivers/auxdisplay/cfag12864b.c               |    4 ++--
 drivers/auxdisplay/cfag12864bfb.c             |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

miguelojeda-drivers-add-LCD-support-6-minor-coding-style-fixes
Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com>
---
diff -uprN -X dontdiff linux-2.6.19-rc1-mod3/Documentation/auxdisplay/cfag12864b-example.c linux/Documentation/auxdisplay/cfag12864b-example.c
--- linux-2.6.19-rc1-mod3/Documentation/auxdisplay/cfag12864b-example.c	2006-11-01 00:39:39.000000000 +0000
+++ linux/Documentation/auxdisplay/cfag12864b-example.c	2006-11-01 01:27:55.000000000 +0000
@@ -203,7 +203,7 @@ void example(unsigned char n)
 	unsigned short i, j;
 	unsigned char matrix[CFAG12864B_WIDTH * CFAG12864B_HEIGHT];
 
-	if(n > EXAMPLES)
+	if (n > EXAMPLES)
 		return;
 
 	printf("Example %i/%i - ", n, EXAMPLES);
@@ -273,7 +273,7 @@ int main(int argc, char *argv[])
 	for (n = 1; n <= EXAMPLES; n++) {
 		example(n);
 		cfag12864b_blit();
-		while(getchar() != '\n');
+		while (getchar() != '\n');
 	}
 
 	cfag12864b_exit();
diff -uprN -X dontdiff linux-2.6.19-rc1-mod3/drivers/auxdisplay/cfag12864b.c linux/drivers/auxdisplay/cfag12864b.c
--- linux-2.6.19-rc1-mod3/drivers/auxdisplay/cfag12864b.c	2006-11-01 00:40:59.000000000 +0000
+++ linux/drivers/auxdisplay/cfag12864b.c	2006-11-01 01:25:12.000000000 +0000
@@ -237,7 +237,7 @@ unsigned char cfag12864b_enable(void)
 
 	mutex_lock(&cfag12864b_mutex);
 
-	if(!cfag12864b_updating) {
+	if (!cfag12864b_updating) {
 		cfag12864b_updating = 1;
 		cfag12864b_queue();
 		ret = 0;
@@ -254,7 +254,7 @@ void cfag12864b_disable(void)
 {
 	mutex_lock(&cfag12864b_mutex);
 
-	if(cfag12864b_updating) {
+	if (cfag12864b_updating) {
 		cfag12864b_updating = 0;
 		cancel_delayed_work(&cfag12864b_work);
 		flush_workqueue(cfag12864b_workqueue);
diff -uprN -X dontdiff linux-2.6.19-rc1-mod3/drivers/auxdisplay/cfag12864bfb.c linux/drivers/auxdisplay/cfag12864bfb.c
--- linux-2.6.19-rc1-mod3/drivers/auxdisplay/cfag12864bfb.c	2006-11-01 00:40:59.000000000 +0000
+++ linux/drivers/auxdisplay/cfag12864bfb.c	2006-11-01 01:26:10.000000000 +0000
@@ -71,7 +71,7 @@ static struct page *cfag12864bfb_vma_nop
 	struct page *page = virt_to_page(cfag12864b_buffer);
 	get_page(page);
 
-	if(type)
+	if (type)
 		*type = VM_FAULT_MINOR;
 
 	return page;
@@ -156,7 +156,7 @@ static int __init cfag12864bfb_init(void
 {
 	int ret;
 
-	if(cfag12864b_enable()) {
+	if (cfag12864b_enable()) {
 		printk(KERN_ERR CFAG12864BFB_NAME ": ERROR: "
 			"can't enable cfag12864b refreshing (being used)\n");
 		return -ENODEV;

             reply	other threads:[~2006-11-01  0:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01  1:40 Miguel Ojeda Sandonis [this message]
2006-11-02  8:51 ` [PATCH update6] drivers: add LCD support Franck Bui-Huu
2006-11-02 13:44   ` Miguel Ojeda
2006-11-02 14:26     ` Franck Bui-Huu
2006-11-02 14:44       ` Miguel Ojeda
2006-11-02 19:13         ` Andrew Morton
2006-11-02 19:33           ` Miguel Ojeda
2006-11-02 20:04             ` Andrew Morton
2006-11-03  0:00               ` David Miller
2006-11-03  6:45                 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061101014057.454c4f43.maxextreme@gmail.com \
    --to=maxextreme@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox