From: "Ed L. Cashin" <ecashin@coraid.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Alan Cox <alan@redhat.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6.19 patch] drivers/block/aoe/aoedev.c: fix NULL dereference
Date: Wed, 1 Nov 2006 11:36:28 -0500 [thread overview]
Message-ID: <20061101163628.GC20570@coraid.com> (raw)
In-Reply-To: <20061101004025.GY27968@stusta.de>
On Wed, Nov 01, 2006 at 01:40:25AM +0100, Adrian Bunk wrote:
> This patch fixes a NULL dereference introduced by
> commit e407a7f6cd143b3ab4eb3d7e1cf882e96b710eb5:
>
> This quite unusual error handling through a switch introduces NULL
> dereferences if exactly one of the two k{c,z}alloc's failed.
Hmm. If exactly one of the two fails, then the value of the switch
conditional is 1 (well, certainly not zero). It will jump over the
zero case, and there's a return in the default case, so I'm having
trouble seeing the danger.
What exactly is Coverity saying? That would be interesting to know.
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2006-11-01 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 0:40 [2.6.19 patch] drivers/block/aoe/aoedev.c: fix NULL dereference Adrian Bunk
2006-11-01 16:36 ` Ed L. Cashin [this message]
2006-11-01 18:38 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101163628.GC20570@coraid.com \
--to=ecashin@coraid.com \
--cc=alan@redhat.com \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox