From: Pavel Machek <pavel@ucw.cz>
To: Yu Luming <luming.yu@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
len.brown@intel.com, Matt Domsch <Matt_Domsch@dell.com>,
Alessandro Guido <alessandro.guido@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
jengelh@linux01.gwdg.de, gelma@gelma.net, ismail@pardus.org.tr,
Richard Hughes <hughsient@gmail.com>
Subject: Re: [patch 2/6] Add display output class support
Date: Thu, 2 Nov 2006 20:51:17 +0000 [thread overview]
Message-ID: <20061102205117.GA4887@ucw.cz> (raw)
In-Reply-To: <200611042113.56913.luming.yu@gmail.com>
Hi!
> Add display output class support
>
> signed-off-by Luming.yu@gmail.com
Hmm, strange characters inside signoff, and I guessthis should be Real
Name <my@ddress>.
> @@ -0,0 +1,129 @@
> +/*
> + * output.c - Display output swither driver
Switcher?
> +static ssize_t video_output_store_state(struct class_device *dev,
> + const char *buf,size_t count)
> +{
> + char *endp;
> + struct output_device *od = to_output_device(dev);
> + int request_state = simple_strtoul(buf,&endp,0);
> + size_t size = endp - buf;
> +
> + if (*endp && isspace(*endp))
> + size++;
> + if (size != count)
> + return -EINVAL;
spaces vs. tabs...
> --- /dev/null
> +++ b/include/linux/output.h
I'm not sure if linux/output.h is not little too generic...
Pavel
--
Thanks for all the (sleeping) penguins.
next prev parent reply other threads:[~2006-11-02 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 13:13 [patch 2/6] Add display output class support Yu Luming
2006-11-02 20:51 ` Pavel Machek [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-11-04 13:10 Yu Luming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061102205117.GA4887@ucw.cz \
--to=pavel@ucw.cz \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=alessandro.guido@gmail.com \
--cc=gelma@gelma.net \
--cc=hughsient@gmail.com \
--cc=ismail@pardus.org.tr \
--cc=jengelh@linux01.gwdg.de \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox