From: Dmitry Torokhov <dtor@insightbb.com>
To: Dave Neuer <mr.fred.smoothie@pobox.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [RFT/PATCH] i8042: remove polling timer (v6)
Date: Fri, 3 Nov 2006 00:56:02 -0500 [thread overview]
Message-ID: <200611030056.03357.dtor@insightbb.com> (raw)
In-Reply-To: <161717d50610300622h15d5e40w4a30e1a95b3c2564@mail.gmail.com>
On Monday 30 October 2006 09:22, Dave Neuer wrote:
> On 10/30/06, Dave Neuer <mr.fred.smoothie@pobox.com> wrote:
> >
> > Maybe I'm missing something, (well actually I'm sure I'm missing
> > somethng). Looking at the code again, it's unclear to me why there is
> > even a call to the ISR in i8042_aux_write, since the latter function
> > already calls i8042_read_data.
> >
>
> Whoops, sorry. I meant i8042_command, which is called by
> i8042_aux_write before the call to i8042_interrupt, already calls
> i8042_read_data.
>
It only calls i8042_read_data() if command is supposed to return data.
Neither I8042_CMD_AUX_SEND nor I8042_CMD_MUX_SEND wait fotr data to come
back.
Anyway, I removed call to i8042_interrupt() from i8042_aux_write() because
it is indeed unnecessary.
--
Dmitry
next prev parent reply other threads:[~2006-11-03 5:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 3:11 [RFT/PATCH] i8042: remove polling timer (v6) Dmitry Torokhov
2006-10-29 23:20 ` Dave Neuer
2006-10-30 3:34 ` Dmitry Torokhov
2006-10-30 9:08 ` Vojtech Pavlik
2006-10-30 13:01 ` Dave Neuer
2006-10-30 14:22 ` Dave Neuer
2006-11-03 5:56 ` Dmitry Torokhov [this message]
2006-11-03 8:18 ` Vojtech Pavlik
2006-11-03 14:08 ` Dmitry Torokhov
2006-11-03 6:03 ` Dmitry Torokhov
2006-11-06 16:22 ` Dave Neuer
2006-11-06 16:48 ` Dmitry Torokhov
2006-11-06 17:09 ` Dave Neuer
2006-11-06 17:21 ` Dave Neuer
2006-11-20 4:36 ` Dave Neuer
2006-11-20 5:04 ` Dave Neuer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611030056.03357.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mr.fred.smoothie@pobox.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox