public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ankita Garg <ankita@in.ibm.com>
To: torvalds@osdl.org
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Fix for LKDTM MEM_SWAPOUT crashpoint
Date: Fri, 3 Nov 2006 12:28:24 +0530	[thread overview]
Message-ID: <20061103065824.GA6790@in.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi,

The MEM_SWAPOUT crashpoint in LKDTM could be broken as some compilers inline the call to shrink_page_list() and symbol lookup for this function name fails.
Replacing it with the function shrink_inactive_list(), which is the only 
function calling shrink_page_list().

Regards,
-- 
Ankita Garg (ankigarg@in.ibm.com)
Linux Technology Center
IBM India Systems & Technology Labs, 
Bangalore, India   

[-- Attachment #2: lkdtm-mem-swapout-fix.patch --]
[-- Type: text/plain, Size: 1266 bytes --]

o Fix for MEM_SWAPOUT crashpoint as some compilers inline the call to 
  shrink_page_list() and symbol lookup for this function name fails. 

Signed-off-by: Ankita Garg <ankita@in.ibm.com>
---
 lkdtm.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Index: linux-2.6.19-rc4-mm2/drivers/misc/lkdtm.c
===================================================================
--- linux-2.6.19-rc4-mm2.orig/drivers/misc/lkdtm.c	2006-11-03 06:20:07.000000000 +0530
+++ linux-2.6.19-rc4-mm2/drivers/misc/lkdtm.c	2006-11-03 06:23:59.000000000 +0530
@@ -157,8 +157,7 @@
 
 struct scan_control;
 
-unsigned long jp_shrink_page_list(struct list_head *page_list,
-                                        struct scan_control *sc)
+unsigned long jp_shrink_inactive_list(unsigned long max_scan, struct zone *zone,				struct scan_control *sc)
 {
 	lkdtm_handler();
 	jprobe_return();
@@ -297,8 +296,8 @@
 		lkdtm.entry = (kprobe_opcode_t*) jp_ll_rw_block;
 		break;
 	case MEM_SWAPOUT:
-		lkdtm.kp.symbol_name = "shrink_page_list";
-		lkdtm.entry = (kprobe_opcode_t*) jp_shrink_page_list;
+		lkdtm.kp.symbol_name = "shrink_inactive_list";
+		lkdtm.entry = (kprobe_opcode_t*) jp_shrink_inactive_list;
 		break;
 	case TIMERADD:
 		lkdtm.kp.symbol_name = "hrtimer_start";

             reply	other threads:[~2006-11-03  7:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-03  6:58 Ankita Garg [this message]
2006-11-03 10:37 ` [PATCH] Fix for LKDTM MEM_SWAPOUT crashpoint Ankita Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061103065824.GA6790@in.ibm.com \
    --to=ankita@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox