public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Amul Shah <amul.shah@unisys.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Vivek Goyal <vgoyal@in.ibm.com>
Subject: Re: [RFC] [PATCH 2.6.19-rc4] kdump panics early in boot when  reserving MP Tables located in high memory
Date: Fri, 3 Nov 2006 17:51:03 +0100	[thread overview]
Message-ID: <200611031751.04056.ak@suse.de> (raw)
In-Reply-To: <1162565722.19677.68.camel@ustr-linux-shaha1.unisys.com>


[Finally dropping that annoying fastboot list from cc. Please never include any closed 
mailing lists in l-k posts. Thanks]

>   That won't worked because in arch/86_64/kernel/e820.c, the exactmap
> parsing clobbers end_pfn_map.

That's a bug imho. It shouldn't do that.

end_pfn_map should be always the highest address in e820 so that we 
can access all firmware tables safely.

-Andi

> 
> static int __init parse_memmap_opt(char *p)
> {
> 	char *oldp;
> 	unsigned long long start_at, mem_size;
> 
> 	if (!strcmp(p, "exactmap")) {
> #ifdef CONFIG_CRASH_DUMP
> 		/* If we are doing a crash dump, we
> 		 * still need to know the real mem
> 		 * size before original memory map is
> 		 * reset.
> 		 */
> 		saved_max_pfn = e820_end_of_ram();
> #endif
> 		end_pfn_map = 0;
> 		e820.nr_map = 0;
> 		userdef = 1;
> 		return 0;
> 	}

  reply	other threads:[~2006-11-03 16:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02 22:24 [RFC] [PATCH 2.6.19-rc4] kdump panics early in boot when reserving MP Tables located in high memory Amul Shah
2006-11-02 23:36 ` [Fastboot] " Vivek Goyal
2006-11-03 14:30   ` Amul Shah
2006-11-03  2:40 ` Andi Kleen
2006-11-03 14:55   ` Amul Shah
2006-11-03 16:51     ` Andi Kleen [this message]
2006-11-03 17:17       ` Vivek Goyal
2006-11-03 19:47         ` Amul Shah
2006-11-03 19:52           ` Andi Kleen
2006-11-03 21:17             ` Amul Shah
2006-11-03 22:01               ` Andi Kleen
2006-11-03 17:40       ` Vivek Goyal
2006-11-03 18:43         ` Andi Kleen
2006-11-03 18:51           ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200611031751.04056.ak@suse.de \
    --to=ak@suse.de \
    --cc=amul.shah@unisys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox