From: Andi Kleen <ak@suse.de>
To: Amul Shah <amul.shah@unisys.com>
Cc: vgoyal@in.ibm.com, LKML <linux-kernel@vger.kernel.org>,
Fastboot mailing list <fastboot@lists.osdl.org>
Subject: Re: [RFC] [PATCH 2.6.19-rc4] kdump panics early in boot when reserving MP Tables located in high memory
Date: Fri, 3 Nov 2006 20:52:05 +0100 [thread overview]
Message-ID: <200611032052.05738.ak@suse.de> (raw)
In-Reply-To: <1162583277.19677.108.camel@ustr-linux-shaha1.unisys.com>
On Friday 03 November 2006 20:47, Amul Shah wrote:
> Andi, Vivek is right. We can use end_pfn_map. My observation is wrong.
Ok. Then my patch should work?
> Vivek, the problem condition is in generic reserve_bootmem_core
> (mm/bootmem.c), where this
> BUG_ON(PFN_DOWN(addr) >= bdata->node_low_pfn);
> checks the target address against the top of that node's memory.
In general these early BUGs should be eliminated - they are always
messy because the kernel exception handlers are not fully functional
yet. printks or worst case panics are better.
-Andi
next prev parent reply other threads:[~2006-11-03 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-02 22:24 [RFC] [PATCH 2.6.19-rc4] kdump panics early in boot when reserving MP Tables located in high memory Amul Shah
2006-11-02 23:36 ` [Fastboot] " Vivek Goyal
2006-11-03 14:30 ` Amul Shah
2006-11-03 2:40 ` Andi Kleen
2006-11-03 14:55 ` Amul Shah
2006-11-03 16:51 ` Andi Kleen
2006-11-03 17:17 ` Vivek Goyal
2006-11-03 19:47 ` Amul Shah
2006-11-03 19:52 ` Andi Kleen [this message]
2006-11-03 21:17 ` Amul Shah
2006-11-03 22:01 ` Andi Kleen
2006-11-03 17:40 ` Vivek Goyal
2006-11-03 18:43 ` Andi Kleen
2006-11-03 18:51 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611032052.05738.ak@suse.de \
--to=ak@suse.de \
--cc=amul.shah@unisys.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox