From: Christoph Hellwig <hch@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Luugi Marsan <luugi.marsan@amd.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Workaround for SB600 SATA ODD issue
Date: Sat, 4 Nov 2006 18:35:15 +0000 [thread overview]
Message-ID: <20061104183515.GA1675@infradead.org> (raw)
In-Reply-To: <1162661809.3160.53.camel@laptopd505.fenrus.org>
On Sat, Nov 04, 2006 at 06:36:49PM +0100, Arjan van de Ven wrote:
> why put this into the ahci struct rather than in the pci device struct?
> In the place you use it you already have the pci device struct already..
> and it's really a pci device property so putting it in that struct makes
> a whole lot of sense conceptually anyway...
I think having a revision field in pci_dev that's initialized by the pci
code early on would be immensivly useful. For now it probably makes sense
to do in ahci what all other drivers do and read it on it's own.
Adding it to the pci core and switching all the drivers over would
be a separate project. Maybe we can sign AMD up for it as a general
kernel contribution thing? :)
next prev parent reply other threads:[~2006-11-04 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 19:00 [PATCH 2/2] Workaround for SB600 SATA ODD issue Luugi Marsan
2006-11-04 12:52 ` Christoph Hellwig
2006-11-04 17:36 ` Arjan van de Ven
2006-11-04 18:35 ` Christoph Hellwig [this message]
2006-11-05 12:45 ` Conke Hu
2006-11-06 12:14 ` Tejun Heo
2006-11-08 13:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061104183515.GA1675@infradead.org \
--to=hch@infradead.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luugi.marsan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox