public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [patch 1/6] video sysfs support: Add dev argument for backlight_device_register.
  2006-11-04 13:07 [patch 1/6] video sysfs support: Add dev argument for backlight_device_register Yu Luming
@ 2006-11-02 21:29 ` Andrew Morton
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-11-02 21:29 UTC (permalink / raw)
  To: Yu Luming
  Cc: Pavel Machek, len.brown, Matt Domsch, Alessandro Guido,
	linux-kernel, linux-acpi, jengelh, gelma, ismail, Richard Hughes


The second patch throws a decent-sized reject against Len's current tree. 
I was going to fix that but I note that the patches have serious whitespace
issues: multiple-spaces are used in many places where hard tabs should be
used.  Please fix all of that up.

Also, there's no overall description of what these patches *do*.  Just a
bunch of one-liners.  But what is the overall end-result?


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [patch 1/6] video sysfs support: Add dev argument for backlight_device_register.
@ 2006-11-04 13:07 Yu Luming
  2006-11-02 21:29 ` Andrew Morton
  0 siblings, 1 reply; 2+ messages in thread
From: Yu Luming @ 2006-11-04 13:07 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Pavel Machek, len.brown, Matt Domsch, Alessandro Guido,
	linux-kernel, linux-acpi, jengelh, gelma, ismail, Richard Hughes


Video sysfs support: add dev argument for backlight_device_register.

signed-off-by   Luming.yu@gmail.com
---

[patch 1/6] video sysfs support: add dev argument for backlight_device_register.
 drivers/video/backlight/backlight.c |    7 +++++--
 include/linux/backlight.h           |    2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
index 27597c5..1d97cdf 100644
--- a/drivers/video/backlight/backlight.c
+++ b/drivers/video/backlight/backlight.c
@@ -190,8 +190,10 @@ static int fb_notifier_callback(struct n
  * Creates and registers new backlight class_device. Returns either an
  * ERR_PTR() or a pointer to the newly allocated device.
  */
-struct backlight_device *backlight_device_register(const char *name, void *devdata,
-						   struct backlight_properties *bp)
+struct backlight_device *backlight_device_register(const char *name,
+	struct device *dev,
+	void *devdata,
+	struct backlight_properties *bp)
 {
 	int i, rc;
 	struct backlight_device *new_bd;
@@ -206,6 +208,7 @@ struct backlight_device *backlight_devic
 	new_bd->props = bp;
 	memset(&new_bd->class_dev, 0, sizeof(new_bd->class_dev));
 	new_bd->class_dev.class = &backlight_class;
+	new_bd->class_dev.dev = dev;
 	strlcpy(new_bd->class_dev.class_id, name, KOBJ_NAME_LEN);
 	class_set_devdata(&new_bd->class_dev, devdata);
 
diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index 75e91f5..a5cf1be 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -54,7 +54,7 @@ struct backlight_device {
 };
 
 extern struct backlight_device *backlight_device_register(const char *name,
-	void *devdata, struct backlight_properties *bp);
+	struct device *dev,void *devdata,struct backlight_properties *bp);
 extern void backlight_device_unregister(struct backlight_device *bd);
 
 #define to_backlight_device(obj) container_of(obj, struct backlight_device, class_dev)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-11-02 21:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-04 13:07 [patch 1/6] video sysfs support: Add dev argument for backlight_device_register Yu Luming
2006-11-02 21:29 ` Andrew Morton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox