* [PATCH] conditionalize some x86-64 options
@ 2006-11-05 0:24 Ulrich Drepper
2006-11-05 1:08 ` Andi Kleen
0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Drepper @ 2006-11-05 0:24 UTC (permalink / raw)
To: Linux Kernel Mailing List, Andrew Morton
Shouldn't the X86_MCE{INTEL,AMD} option depend on the other
manufacturer's CPU not being explicitly selected?
Signed-off-by: Ulrich Drepper <drepper@redhat.com>
diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
index 010d226..f414fe2 100644
--- a/arch/x86_64/Kconfig
+++ b/arch/x86_64/Kconfig
@@ -470,7 +470,7 @@ config X86_MCE
config X86_MCE_INTEL
bool "Intel MCE features"
- depends on X86_MCE && X86_LOCAL_APIC
+ depends on X86_MCE && X86_LOCAL_APIC && !MK8
default y
help
Additional support for intel specific MCE features such as
@@ -478,7 +478,7 @@ config X86_MCE_INTEL
config X86_MCE_AMD
bool "AMD MCE features"
- depends on X86_MCE && X86_LOCAL_APIC
+ depends on X86_MCE && X86_LOCAL_APIC && !MPSC
default y
help
Additional support for AMD specific MCE features such as
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] conditionalize some x86-64 options 2006-11-05 0:24 [PATCH] conditionalize some x86-64 options Ulrich Drepper @ 2006-11-05 1:08 ` Andi Kleen 2006-11-06 23:19 ` Ulrich Drepper 0 siblings, 1 reply; 4+ messages in thread From: Andi Kleen @ 2006-11-05 1:08 UTC (permalink / raw) To: Ulrich Drepper; +Cc: Linux Kernel Mailing List, Andrew Morton On Sunday 05 November 2006 01:24, Ulrich Drepper wrote: > Shouldn't the X86_MCE{INTEL,AMD} option depend on the other > manufacturer's CPU not being explicitly selected? No -- the CPU selection on x86-64 means "optimize for", but doesn't mean don't run on other CPUs. -Andi ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] conditionalize some x86-64 options 2006-11-05 1:08 ` Andi Kleen @ 2006-11-06 23:19 ` Ulrich Drepper 2006-11-06 23:50 ` Andi Kleen 0 siblings, 1 reply; 4+ messages in thread From: Ulrich Drepper @ 2006-11-06 23:19 UTC (permalink / raw) To: Andi Kleen; +Cc: Linux Kernel Mailing List, Andrew Morton On 11/4/06, Andi Kleen <ak@suse.de> wrote: > No -- the CPU selection on x86-64 means "optimize for", but doesn't > mean don't run on other CPUs. Then please explain this: config X86_HT bool depends on SMP && !MK8 default y ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] conditionalize some x86-64 options 2006-11-06 23:19 ` Ulrich Drepper @ 2006-11-06 23:50 ` Andi Kleen 0 siblings, 0 replies; 4+ messages in thread From: Andi Kleen @ 2006-11-06 23:50 UTC (permalink / raw) To: Ulrich Drepper; +Cc: Linux Kernel Mailing List, Andrew Morton On Tuesday 07 November 2006 00:19, Ulrich Drepper wrote: > On 11/4/06, Andi Kleen <ak@suse.de> wrote: > > No -- the CPU selection on x86-64 means "optimize for", but doesn't > > mean don't run on other CPUs. > > Then please explain this: > > config X86_HT > bool > depends on SMP && !MK8 > default y HT scheduler is just an optimization -- not needed for any functionality. Doesn't break anything when not there. But I agree the && !MK8 is bogus and should be probably removed (or perhaps moved into a default) -Andi ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-11-06 23:50 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-11-05 0:24 [PATCH] conditionalize some x86-64 options Ulrich Drepper 2006-11-05 1:08 ` Andi Kleen 2006-11-06 23:19 ` Ulrich Drepper 2006-11-06 23:50 ` Andi Kleen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox