Re: [Opps] Invalid opcode

Andi Kleen
2006-11-05T23:33:21Z

On Monday 06 November 2006 00:13, Zachary Amsden wrote:
> S.Çağlar Onur wrote:
> > Hmm, Novell bugzilla seems has similiar issues,
> > https://bugzilla.novell.com/show_bug.cgi?id=204647 and its duplicated ones
> > gaves same or similiar panic outputs.
> >
> >
> >> Previously we avoided converting i386 cpu bootup fully to the new state
> >> machine because it is very fragile, but it's possible that there
> >> is no other choice than to do it properly. Or maybe another kludge
> >> is possible.
> >>
>
> Yes, this is some kind of softirq race during init.

Yes, the callbacks run at the wrong time. Unlike modern architectures
i386 doesn't do callback cpu boot callback repeat, but boot all cpus then callback.

But the strange thing is that the BP hits it. Normally the new CPU
hit it because it tried to run a timer interrupt before the callback
ran and initialized all the per CPU state (this happened often
when dual core CPUs were first introduced for some reason)

In this case it looks like the AP managed to queue a tasklet before
the cpu up callback runs.

I suppose we'll either need to convert i386 really over to standard
cpu_up() or add some additional spinlocks to stop the APs with interrupts
off before the callbacks start to run.

-Andi