public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, arjan <arjan@infradead.org>
Subject: Re: [PATCH] debug workqueue locking sanity
Date: Mon, 6 Nov 2006 08:23:23 +0100	[thread overview]
Message-ID: <20061106072323.GC29772@elte.hu> (raw)
In-Reply-To: <1162758984.14695.22.camel@lappy>


* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> +		if (unlikely(in_atomic()
> +#ifdef CONFIG_LOCKDEP
> +			|| current->lockdep_depth > 0
> +#endif
> +			)) {

i agree with this patch, but shouldnt this #ifdef be hidden via some 
sort of lockdep_depth() inline in lockdep.h that just returns 0 if 
!LOCKDEP?

	Ingo

  reply	other threads:[~2006-11-06  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-05 20:36 [PATCH] debug workqueue locking sanity Peter Zijlstra
2006-11-06  7:23 ` Ingo Molnar [this message]
2006-11-06  7:36   ` [PATCH] debug workqueue locking sanity -v2 Peter Zijlstra
2006-11-06  7:46     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061106072323.GC29772@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox