public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: ext2-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] ext4_ext_split(): remove dead code
Date: Mon, 6 Nov 2006 11:05:54 +0100	[thread overview]
Message-ID: <20061106100554.GH5778@stusta.de> (raw)

The Coverity checker noted that this was dead code, since in all places 
above in this function, "err" is immediately checked.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6/fs/ext4/extents.c.old	2006-11-06 11:02:09.000000000 +0100
+++ linux-2.6/fs/ext4/extents.c	2006-11-06 11:02:29.000000000 +0100
@@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *hand
 	}
 
 	/* insert new index */
-	if (err)
-		goto cleanup;
-
 	err = ext4_ext_insert_index(handle, inode, path + at,
 				    le32_to_cpu(border), newblock);
 


                 reply	other threads:[~2006-11-06 10:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061106100554.GH5778@stusta.de \
    --to=bunk@stusta.de \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox