public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: PATCH? hrtimer_wakeup: fix a theoretical race wrt rt_mutex_slowlock()
Date: Mon, 6 Nov 2006 17:15:02 +0300	[thread overview]
Message-ID: <20061106141502.GA164@oleg> (raw)
In-Reply-To: <Pine.LNX.4.58.0611060729370.14553@gandalf.stny.rr.com>

On 11/06, Steven Rostedt wrote:
> 
> Acked-by: Steven Rostedt <rostedt@goodmis.org>

Thanks.

But on the other hand we probably have a similar code (set condition +
wake_up_process()) in other places too, and __wake_up(wait_queue_head_t)
has (in theory) the same problem. Probably we can add something like

	smp_wmb_unless_spin_lock_implies_memory_barrier_on_this_arch()

somewhere in try_to_wake_up(). I dunno.

Oleg.


  reply	other threads:[~2006-11-06 13:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-05 19:34 PATCH? hrtimer_wakeup: fix a theoretical race wrt rt_mutex_slowlock() Oleg Nesterov
2006-11-05 22:29 ` Linus Torvalds
2006-11-05 22:53   ` Steven Rostedt
2006-11-05 23:08     ` Oleg Nesterov
2006-11-06  3:08     ` Linus Torvalds
2006-11-06 12:09       ` Oleg Nesterov
2006-11-06 12:26         ` Steven Rostedt
2006-11-05 22:53   ` Oleg Nesterov
2006-11-06  8:57   ` Benjamin Herrenschmidt
2006-11-06 12:35     ` Steven Rostedt
2006-11-06 20:53       ` Benjamin Herrenschmidt
2006-11-06 21:17         ` Steven Rostedt
2006-11-06 21:41           ` Benjamin Herrenschmidt
2006-11-06 12:31 ` Steven Rostedt
2006-11-06 14:15   ` Oleg Nesterov [this message]
2006-11-06 14:11     ` Steven Rostedt
2006-11-06 15:05       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061106141502.GA164@oleg \
    --to=oleg@tv-sign.ru \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox