* [PATCH] a minor fix for set_mb() in Documentation/memory-barriers.txt
@ 2006-11-06 15:03 Oleg Nesterov
2006-11-08 11:29 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2006-11-06 15:03 UTC (permalink / raw)
To: David Howells; +Cc: Steven Rostedt, Andrew Morton, Linus Torvalds, linux-kernel
set_mb() is used by set_current_state() which needs mb(), not wmb().
I think it would be right to assume that set_mb() implies mb(), all
arches seem to do just this.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- d/Documentation/memory-barriers.txt~ 2006-11-06 17:43:36.000000000 +0300
+++ d/Documentation/memory-barriers.txt 2006-11-06 17:44:26.000000000 +0300
@@ -1016,7 +1016,7 @@ There are some more advanced barrier fun
(*) set_mb(var, value)
- This assigns the value to the variable and then inserts at least a write
+ This assigns the value to the variable and then inserts a full memory
barrier after it, depending on the function. It isn't guaranteed to
insert anything more than a compiler barrier in a UP compilation.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] a minor fix for set_mb() in Documentation/memory-barriers.txt
2006-11-06 15:03 [PATCH] a minor fix for set_mb() in Documentation/memory-barriers.txt Oleg Nesterov
@ 2006-11-08 11:29 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2006-11-08 11:29 UTC (permalink / raw)
To: Oleg Nesterov
Cc: David Howells, Steven Rostedt, Andrew Morton, Linus Torvalds,
linux-kernel
Oleg Nesterov <oleg@tv-sign.ru> wrote:
> set_mb() is used by set_current_state() which needs mb(), not wmb().
> I think it would be right to assume that set_mb() implies mb(), all
> arches seem to do just this.
Yes, you're right. Copy'n'paste error from the text about set_wmb() I think.
Acked-By: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-08 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-06 15:03 [PATCH] a minor fix for set_mb() in Documentation/memory-barriers.txt Oleg Nesterov
2006-11-08 11:29 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox