From: Greg KH <gregkh@suse.de>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Wolfgang M?es <wolfgang@iksw-muees.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc4] usb auerswald possible memleak fix
Date: Tue, 7 Nov 2006 09:27:34 +0900 [thread overview]
Message-ID: <20061107002734.GA5236@suse.de> (raw)
In-Reply-To: <200611070031.52051.m.kozlowski@tuxland.pl>
On Tue, Nov 07, 2006 at 12:31:51AM +0100, Mariusz Kozlowski wrote:
> Witam,
>
> > Hello,
> >
> > There is possible memleak in auerbuf_setup(). Fix is to replace kfree() with auerbuf_free().
> > An argument to usb_free_urb() does not need a check as usb_free_urb() already does that. Not sure if I should
> > send this in two separate patches. The patch is against 2.6.19-rc4 (not -mm).
>
> As I posted the bigger usb_free_urb() patch in another mail this one
> should do only one thing which is to fix possible memory leak in
> auerbuf_setup().
That is a big patch, care to split it up into smaller pieces like this
one so that it is easier to review and apply?
thanks,
greg k-h
next prev parent reply other threads:[~2006-11-07 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 18:03 [PATCH 2.6.19-rc4] usb auerswald possible memleak fix Mariusz Kozlowski
2006-11-06 23:31 ` Mariusz Kozlowski
2006-11-07 0:27 ` Greg KH [this message]
2006-11-07 9:25 ` Mariusz Kozlowski
2006-11-07 11:53 ` Greg KH
2006-11-07 20:02 ` Wolfgang Mües
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107002734.GA5236@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=wolfgang@iksw-muees.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox