From: Dave Jones <davej@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>,
akpm@osdl.org, Wilco Beekhuizen <wilcobeekhuizen@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: VIA IRQ quirk missing PCI ids since 2.6.16.17
Date: Mon, 6 Nov 2006 20:25:19 -0500 [thread overview]
Message-ID: <20061107012519.GC25719@redhat.com> (raw)
In-Reply-To: <1162847625.10086.36.camel@localhost.localdomain>
On Mon, Nov 06, 2006 at 09:13:45PM +0000, Alan Cox wrote:
> +static const struct pci_device_id via_vlink_fixup_tbl[] = {
> + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233_0), 17},
> + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233A), 17 },
> + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233C_0), 17 },
> + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8235), 16 },
> + /* May not be needed for the 8237 */
> + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237), 15 },
> + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237A), 15 },
> { 0, },
This got me wondering what PCI_VDEVICE was, so I went looking.
It's a libata'ism it seems with the comment..
/* move to PCI layer? */
Which sounds like a good idea to me. But until this is moved,
does quirks.c actually compile with this patch? I don't see
an include of linux/libata.h there.
When it gets moved to the PCI layer, I wonder if it'd be worth
doing the same thing to the second argument, so that we'd be
able to do..
{ PCI_VDEVICE(VIA, VIA_8233_0), 17},
Or maybe even..
{ PCI_VDEVICE(VIA, 8233_0), 17},
?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-11-07 1:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 11:38 VIA IRQ quirk missing PCI ids since 2.6.16.17 Wilco Beekhuizen
2006-11-06 12:47 ` Sergio Monteiro Basto
2006-11-06 21:13 ` Alan Cox
2006-11-07 1:25 ` Dave Jones [this message]
2006-11-07 1:34 ` Alan Cox
2006-11-08 8:54 ` Wilco Beekhuizen
2006-11-08 12:43 ` Sergio Monteiro Basto
2006-11-08 14:55 ` Wilco Beekhuizen
2006-11-08 15:19 ` Alan Cox
2006-11-07 4:07 ` Greg KH
2006-11-07 8:31 ` Jeff Garzik
2006-11-08 17:22 ` Sergey Vlasov
2006-11-08 18:05 ` Alan Cox
2006-11-08 20:33 ` Sergey Vlasov
2006-11-06 13:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061107012519.GC25719@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=sergio@sergiomb.no-ip.org \
--cc=wilcobeekhuizen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox