Re: VIA IRQ quirk missing PCI ids since 2.6.16.17

Greg KH
2006-11-07T04:08:13Z

On Mon, Nov 06, 2006 at 08:25:19PM -0500, Dave Jones wrote:
> On Mon, Nov 06, 2006 at 09:13:45PM +0000, Alan Cox wrote:
>
> > +static const struct pci_device_id via_vlink_fixup_tbl[] = {
> > + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233_0), 17},
> > + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233A), 17 },
> > + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8233C_0), 17 },
> > + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8235), 16 },
> > + /* May not be needed for the 8237 */
> > + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237), 15 },
> > + { PCI_VDEVICE(VIA, PCI_DEVICE_ID_VIA_8237A), 15 },
> > { 0, },
>
> This got me wondering what PCI_VDEVICE was, so I went looking.
> It's a libata'ism it seems with the comment..
>
> /* move to PCI layer? */

I have no objection to moving this to pci.h. Feel free to send me a
patch.

thanks,

greg k-h