public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: ak@suse.de, akpm@osdl.org
Cc: shaohua.li@intel.com, linux-kernel@vger.kernel.org,
	discuss@x86-64.org, ashok.raj@intel.com,
	suresh.b.siddha@intel.com
Subject: Re: [patch 2/4] introduce the mechanism of disabling cpu hotplug control
Date: Tue, 7 Nov 2006 17:40:25 -0800	[thread overview]
Message-ID: <20061107174024.B5401@unix-os.sc.intel.com> (raw)
In-Reply-To: <20061107173624.A5401@unix-os.sc.intel.com>; from suresh.b.siddha@intel.com on Tue, Nov 07, 2006 at 05:36:24PM -0800

Add 'cpu_hotplug_no_control' and when set, the hotplug control file("online")
will not be added under /sys/devices/system/cpu/cpuX/

Next patch doing PCI quirks will use this.

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---

diff --git a/arch/i386/kernel/topology.c b/arch/i386/kernel/topology.c
index 07d6da3..9b766e7 100644
--- a/arch/i386/kernel/topology.c
+++ b/arch/i386/kernel/topology.c
@@ -40,14 +40,22 @@ int arch_register_cpu(int num)
 	 * restrictions and assumptions in kernel. This basically
 	 * doesnt add a control file, one cannot attempt to offline
 	 * BSP.
+	 *
+	 * Also certain PCI quirks require to remove this control file
+	 * for all CPU's.
 	 */
+#ifdef CONFIG_HOTPLUG_CPU
+	if (!num || cpu_hotplug_no_control)
+#else
 	if (!num)
+#endif
 		cpu_devices[num].cpu.no_control = 1;
 
 	return register_cpu(&cpu_devices[num].cpu, num);
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
+int cpu_hotplug_no_control;
 
 void arch_unregister_cpu(int num) {
 	return unregister_cpu(&cpu_devices[num].cpu);
diff --git a/include/asm-i386/cpu.h b/include/asm-i386/cpu.h
index b1bc7b1..3c5da33 100644
--- a/include/asm-i386/cpu.h
+++ b/include/asm-i386/cpu.h
@@ -13,6 +13,7 @@ struct i386_cpu {
 extern int arch_register_cpu(int num);
 #ifdef CONFIG_HOTPLUG_CPU
 extern void arch_unregister_cpu(int);
+extern int cpu_hotplug_no_control;
 #endif
 
 DECLARE_PER_CPU(int, cpu_state);

  reply	other threads:[~2006-11-08  2:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08  1:33 [patch 0/4] i386, x86_64: fix the irqbalance quirk for E7520/E7320/E7525 Siddha, Suresh B
2006-11-08  1:36 ` [patch 1/4] add write_pci_config_byte() to direct PCI access routines Siddha, Suresh B
2006-11-08  1:40   ` Siddha, Suresh B [this message]
2006-11-08  1:43     ` [patch 3/4] x86_64: add genapic_force Siddha, Suresh B
2006-11-08  1:46       ` [patch 4/4] fix the irqbalance quirk for E7320/E7520/E7525 Siddha, Suresh B
2006-11-08  3:54     ` [patch 2/4] introduce the mechanism of disabling cpu hotplug control Andrew Morton
2006-11-08  4:01       ` Siddha, Suresh B
2006-11-08  4:35         ` Andrew Morton
2006-11-08  5:23           ` Siddha, Suresh B
2006-11-11  0:43             ` [patch] change the 'no_control' field to 'hotpluggable' in the struct cpu Siddha, Suresh B
2006-11-08  4:07 ` [patch 0/4] i386, x86_64: fix the irqbalance quirk for E7520/E7320/E7525 Andrew Morton
2006-11-08  4:06   ` Siddha, Suresh B

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061107174024.B5401@unix-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=ashok.raj@intel.com \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox