public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: General network driver suspend/resume (was e1000 carrier related)
Date: Wed, 8 Nov 2006 11:54:14 -0800	[thread overview]
Message-ID: <20061108115414.7e089a58@freekitty> (raw)
In-Reply-To: 20061108120407.GA9506@elf.ucw.cz

On Wed, 8 Nov 2006 13:04:07 +0100
Pavel Machek <pavel@ucw.cz> wrote:

> Hi!
> 
> > >>This behavior differs from every other network card, and is also present 
> > >>in the
> > >>7.3* version of the driver from sourceforge.
> > >>
> > >>I think the e1000 should try to raise the link during the probe, so that 
> > >>it
> > >>works properly, without having to set ifconfig ethX up first.
> > >
> > >I think you should cc e1000 maintainers, and perhaps provide a patch....
> > 
> > I've read it and not come up with an answer due to some other issues at 
> > hand. E1000 hardware works differently and this has been asked before, but 
> > the cards itself are in low power state when down. Changing this to bring 
> > up the link would make the card start to consume lots more power, which 
> > would automatically suck enormously for anyone using a laptop.
> 
> Well, maybe E1000 should behave as the other cards behave, and
> different solution needs to be found for power saving? ifconfig eth0
> suspend?
> 
> 									Pavel
>  
> 

The standard which all network drivers should use is:

module insertion:
	start in initial powerdown state

open:
	power up, bring up link

stop:
	bring down link
	return to powerdown state unless WOL is set.
	if doing WOL go to lowest power sensing state

suspend:
	same as stop

resume:
	same as open

module removal:
	stop already called so device should be in power down state.


Since suspend is basically same as stop, and resume is open
I am going to investigate doing suspend/resume in the network device layer
(unless subclassed by driver), so we can rip out the suspend/resume hook
from many network drivers. There will still be boards like sky2
that need own suspend/resume to deal with dual port etc.

-- 
Stephen Hemminger <shemminger@osdl.org>

  reply	other threads:[~2006-11-08 19:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06  1:31 e1000/ICH8LAN weirdness - no ethtool link until initially forced up Robin H. Johnson
2006-11-07  7:14 ` Pavel Machek
2006-11-07 15:51   ` Auke Kok
2006-11-07 19:35     ` Theodore Tso
2006-11-08 15:59       ` Auke Kok
2006-11-07 21:31     ` Robin H. Johnson
2006-11-07 22:32       ` Auke Kok
2006-11-08  3:56         ` Robin H. Johnson
2006-11-08 12:04     ` Pavel Machek
2006-11-08 19:54       ` Stephen Hemminger [this message]
2006-11-08 21:10         ` General network driver suspend/resume (was e1000 carrier related) Auke Kok
2006-11-08 21:33           ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061108115414.7e089a58@freekitty \
    --to=shemminger@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox